Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43232: Prohibit previously deprecated operations on TransportSocket #24538

Merged
merged 3 commits into from
Jun 30, 2021

Conversation

illia-v
Copy link
Contributor

@illia-v illia-v commented Feb 15, 2021

Probably the warning should be updated in Python 3.8 and Python 3.9 to avoid confusion ("will be prohibited in asyncio 3.9" -> "will be prohibited in Python 3.10").

https://bugs.python.org/issue43232

@illia-v
Copy link
Contributor Author

illia-v commented Feb 15, 2021

BTW, I didn't document the change in What's New, because it looks like the class is pretty low-level. If it should be documented there, please let me know in what section: neither "Deprecated" nor "Removed" seem to suite.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 18, 2021
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of explicitly raising RuntimeError, just remove the corresponding methods.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@serhiy-storchaka serhiy-storchaka removed the stale Stale PR or inactive for long period of time. label Jun 28, 2021
@illia-v
Copy link
Contributor Author

illia-v commented Jun 29, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

@sbourdeauducq
Copy link

Why was ioctl removed? How do we set up TCP keepalive on Windows without it?

@serhiy-storchaka
Copy link
Member

The warning was added in 3.8 (see #81208), 4 years ago. This PR was merged 2 years ago. Please open a new issue for your use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants