-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-43232: Prohibit previously deprecated operations on TransportSocket #24538
Conversation
BTW, I didn't document the change in What's New, because it looks like the class is pretty low-level. If it should be documented there, please let me know in what section: neither "Deprecated" nor "Removed" seem to suite. |
This PR is stale because it has been open for 30 days with no activity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of explicitly raising RuntimeError, just remove the corresponding methods.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I have made the requested changes; please review again |
Thanks for making the requested changes! @serhiy-storchaka: please review the changes made to this pull request. |
Why was ioctl removed? How do we set up TCP keepalive on Windows without it? |
The warning was added in 3.8 (see #81208), 4 years ago. This PR was merged 2 years ago. Please open a new issue for your use case. |
Probably the warning should be updated in Python 3.8 and Python 3.9 to avoid confusion ("will be prohibited in asyncio 3.9" -> "will be prohibited in Python 3.10").
https://bugs.python.org/issue43232