Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Use list[int] instead of List[int] (etc.) in a few more places #22524

Merged
merged 2 commits into from
Oct 3, 2020
Merged

[doc] Use list[int] instead of List[int] (etc.) in a few more places #22524

merged 2 commits into from
Oct 3, 2020

Conversation

andresdelfino
Copy link
Contributor

@andresdelfino andresdelfino commented Oct 3, 2020 •
edited by miss-islington
Loading

This changes a few occurrences left behind by #22340.

Automerge-Triggered-By: @gvanrossum

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 3, 2020
gvanrossum
gvanrossum approved these changes Oct 3, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You wouldn't be collecting points for HacktoberFest would you? :-) I wish you had combined all those little patches into one PR.

@gvanrossum gvanrossum changed the title [doc] Leverage the fact that the actual types can now be indexed for typing [doc] Use list[int] instead of List[int] (etc.) in a few more places Oct 3, 2020
@miss-islington miss-islington merged commit 7f54e56 into python:master Oct 3, 2020
@miss-islington
Copy link
Contributor

@andresdelfino: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor

@andresdelfino: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

1 similar comment
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

@miss-islington
Copy link
Contributor

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2020
@andresdelfino @miss-islington
[doc] Use list[int] instead of List[int] (etc.) in a few more places (p…
8e7e21b 
…ythonGH-22524)

This changes a few occurrences left behind by pythonGH-22340.

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit 7f54e56)

Co-authored-by: Andre Delfino <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Oct 3, 2020
@bedevere-bot
Copy link

GH-22531 is a backport of this pull request to the 3.9 branch.

@andresdelfino
Copy link
Contributor Author

You wouldn't be collecting points for HacktoberFest would you? :-) I wish you had combined all those little patches into one PR.

Yeah, the thing is that I'm doing a talk on type hints soon (quite excited about this :) and I'm reading the docs meticulously, so I'm finding occurrences I previously didn't get by by just grepping it :P

Sorry about that.

@andresdelfino andresdelfino deleted the use_actual_generic_types_2 branch October 3, 2020 22:12
@gvanrossum
Copy link
Member

Awesome, thanks for all the doc fixes, good luck with the talk!

miss-islington added a commit that referenced this pull request Oct 3, 2020
@miss-islington @andresdelfino
[doc] Use list[int] instead of List[int] (etc.) in a few more places (G…
5f9a08d 
…H-22524)

This changes a few occurrences left behind by GH-22340.

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit 7f54e56)

Co-authored-by: Andre Delfino <[email protected]>
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
@miss-islington @andresdelfino @ambv
[doc] Use list[int] instead of List[int] (etc.) in a few more places (p…
fd510e3 
…ythonGH-22524)

This changes a few occurrences left behind by pythonGH-22340.

Automerge-Triggered-By: @gvanrossum
(cherry picked from commit 7f54e56)

Co-authored-by: Andre Delfino <[email protected]>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@andresdelfino
[doc] Use list[int] instead of List[int] (etc.) in a few more places (p…
39b5ae0 
…ythonGH-22524)

This changes a few occurrences left behind by python#22340.

Automerge-Triggered-By: @gvanrossum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andresdelfino @miss-islington @bedevere-bot @gvanrossum @the-knights-who-say-ni