-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple Documentation fix: Missing link to return type class. #21291
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Volker-Weissmann, thanks for improving the documentation!
While it is not always required for simple documentation changes, the CLA will be needed if you want to contribute more significant changes to Python in the future so please follow the advice of @the-knights-who-say-ni to sign it :-)
Also, the documentation wraps the lines at 80 characters, can you please update your PR so that it's consistent with the rest of the file?
I signed the CLA a few minutes ago and added a line break. |
Thanks, also bpo-17805 is not exactly related to this change. As it is a simple documentation change, a bpo entry may not be required but we should not use another one that is not strictly this issue. I think you can just change the title of the PR to something like "Add link in multiprocessing documentation". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the contribution!
Thanks @Volker-Weissmann for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
…H-21291) Just a simple documentation fix: apply_async and map_async return a "multiprocessing.pool.AsyncResult Object", not a "result object". (cherry picked from commit f9bf015) Co-authored-by: Volker-Weissmann <[email protected]>
GH-21561 is a backport of this pull request to the 3.9 branch. |
GH-21562 is a backport of this pull request to the 3.8 branch. |
…H-21291) Just a simple documentation fix: apply_async and map_async return a "multiprocessing.pool.AsyncResult Object", not a "result object". (cherry picked from commit f9bf015) Co-authored-by: Volker-Weissmann <[email protected]>
Just a simple documentation fix: apply_async and map_async return a "multiprocessing.pool.AsyncResult Object", not a "result object". (cherry picked from commit f9bf015) Co-authored-by: Volker-Weissmann <[email protected]>
Just a simple documentation fix: apply_async and map_async return a "multiprocessing.pool.AsyncResult Object", not a "result object". (cherry picked from commit f9bf015) Co-authored-by: Volker-Weissmann <[email protected]>
…H-21291) Just a simple documentation fix: apply_async and map_async return a "multiprocessing.pool.AsyncResult Object", not a "result object".
…H-21291) Just a simple documentation fix: apply_async and map_async return a "multiprocessing.pool.AsyncResult Object", not a "result object".
…H-21291) Just a simple documentation fix: apply_async and map_async return a "multiprocessing.pool.AsyncResult Object", not a "result object".
…H-21291) Just a simple documentation fix: apply_async and map_async return a "multiprocessing.pool.AsyncResult Object", not a "result object".
Just a simple documentation fix: apply_async and map_async return a "multiprocessing.pool.AsyncResult Object", not a "result object".
https://bugs.python.org/issue17805
Automerge-Triggered-By: @csabella