Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39877: Fix PyEval_RestoreThread() for daemon threads #18808

Closed
wants to merge 1 commit into from
Closed

bpo-39877: Fix PyEval_RestoreThread() for daemon threads #18808

wants to merge 1 commit into from

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 6, 2020 •
edited by bedevere-bot
Loading

@vstinner
Copy link
Member Author

vstinner commented Mar 6, 2020

While this change does fix https://bugs.python.org/issue39877 it leaves Python in a sad state. Daemon threads simply loop on atttempting to take the GIL, but exit_thread_if_finalizing() is not called.

I wrote a more advanced solution: PR #18811.

@vstinner vstinner closed this Mar 6, 2020
@vstinner vstinner deleted the daemon_thread_runtime branch March 6, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot