bpo-39793: use the same domain on make_msgid tests #18698
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18698 +/- ##
=========================================
Coverage 82.13% 82.13%
=========================================
Files 1956 1955 -1
Lines 589974 584604 -5370
Branches 44484 44484
=========================================
- Hits 484572 480164 -4408
+ Misses 95750 94794 -956
+ Partials 9652 9646 -6
Continue to review full report at Codecov.
|
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @akuchling: please review the changes made to this pull request. |
|
@python/email-team -- do you want to veto this PR? Otherwise I'll go ahead and merge it. |
|
@akuchling no objection so far, 12 days. |
|
@akuchling: Please replace |
|
Thanks @isidentical for the PR, and @akuchling for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
* bpo-39793: use same domain on make_msgid tests * apply suggestions (cherry picked from commit 5565c30) Co-authored-by: Batuhan Taşkaya <[email protected]>
|
GH-19554 is a backport of this pull request to the 3.8 branch. |
* bpo-39793: use same domain on make_msgid tests * apply suggestions (cherry picked from commit 5565c30) Co-authored-by: Batuhan Taşkaya <[email protected]>
|
GH-19555 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit 5565c30) Co-authored-by: Batuhan Taşkaya <[email protected]>
(cherry picked from commit 5565c30) Co-authored-by: Batuhan Taşkaya <[email protected]>
* master: (1985 commits) bpo-40179: Fix translation of #elif in Argument Clinic (pythonGH-19364) bpo-35967: Skip test with `uname -p` on Android (pythonGH-19577) bpo-40257: Improve help for the typing module (pythonGH-19546) Fix two typos in multiprocessing (pythonGH-19571) bpo-40286: Use random.randbytes() in tests (pythonGH-19575) bpo-40286: Makes simpler the relation between randbytes() and getrandbits() (pythonGH-19574) bpo-39894: Route calls from pathlib.Path.samefile() to os.stat() via the path accessor (pythonGH-18836) bpo-39897: Remove needless `Path(self.parent)` call, which makes `is_mount()` misbehave in `Path` subclasses. (pythonGH-18839) bpo-40282: Allow random.getrandbits(0) (pythonGH-19539) bpo-40302: UTF-32 encoder SWAB4() macro use a|b rather than a+b (pythonGH-19572) bpo-40302: Replace PY_INT64_T with int64_t (pythonGH-19573) bpo-40286: Add randbytes() method to random.Random (pythonGH-19527) bpo-39901: Move `pathlib.Path.owner()` and `group()` implementations into the path accessor. (pythonGH-18844) bpo-40300: Allow empty logging.Formatter.default_msec_format. (pythonGH-19551) bpo-40302: Add pycore_byteswap.h header file (pythonGH-19552) bpo-40287: Fix SpooledTemporaryFile.seek() return value (pythonGH-19540) Minor modernization and readability improvement to the tokenizer example (pythonGH-19558) bpo-40294: Fix _asyncio when module is loaded/unloaded multiple times (pythonGH-19542) Fix parameter names in assertIn() docs (pythonGH-18829) bpo-39793: use the same domain on make_msgid tests (python#18698) ...
https://bugs.python.org/issue39793