Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "bpo-39413: Implement os.unsetenv() on Windows (GH-18104)" #18124

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Revert "bpo-39413: Implement os.unsetenv() on Windows (GH-18104)" #18124

merged 1 commit into from
Jan 22, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 22, 2020 •
edited by bedevere-bot
Loading

@vstinner
Copy link
Member Author

The change introduced a regression: https://bugs.python.org/issue39413#msg360404

@vstinner vstinner mentioned this pull request Jan 22, 2020
Closed
@vstinner vstinner merged commit b73dd02 into python:master Jan 22, 2020
@vstinner vstinner deleted the revert_unsetenv branch January 22, 2020 20:11
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@vstinner @shihai1991
Revert "bpo-39413: Implement os.unsetenv() on Windows (pythonGH-18104)…
641cc57 
…" (pythonGH-18124)

This reverts commit 56cd371.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot