bpo-39413: Use _wputenv(), not SetEnvironmentVariableW() #18107
Closed
+22
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't implement os.unsetenv() in C using SetEnvironmentVariableW(name, NULL) anymore, but implement it in Python as os.putenv(name, ""). _wputenv() is preferred since it updates the CRT, whereas SetEnvironmentVariableW(name, NULL) does not. Replace also lambda functions with regular functions to get named functions, to ease debug.
| else: | ||
| if "putenv" not in __all__: | ||
| __all__.append("putenv") | ||
|
|
||
| try: | ||
| _unsetenv = unsetenv | ||
| except NameError: | ||
| _unsetenv = lambda key: _putenv(key, "") | ||
| if name == 'nt': |
There was a problem hiding this comment.
This looks too complicated and obscure. Many lines are duplicated with small differences. Would not it be easier to implement nt.unsetenv() on C?
|
@serhiy-storchaka: "This looks too complicated and obscure. Many lines are duplicated with small differences. Would not it be easier to implement nt.unsetenv() on C?" Ok, I wrote PR #18115 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't implement os.unsetenv() in C using
SetEnvironmentVariableW(name, NULL) anymore, but implement it in
Python as os.putenv(name, ""). _wputenv() is preferred since it
updates the CRT, whereas SetEnvironmentVariableW(name, NULL) does
not.
Replace also lambda functions with regular functions to get named
functions, to ease debug.
https://bugs.python.org/issue39413