bpo-38415 @asynccontextmanager as decorators like @contextmanager #16667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Please create a bpo issue and generate a |
1st1
approved these changes
Oct 8, 2019
fried
changed the title
fried
force-pushed
the
asynccontextmanager_decorator
branch
from
b6fad49 to
cd79d6c
Compare
fried
changed the title
|
alright |
|
@ncoghlan Nick, do you want to take a look at this? Looks good to me. |
asvetlov
approved these changes
Oct 15, 2019
ambv
force-pushed
the
asynccontextmanager_decorator
branch
from
cd79d6c to
8890d0e
Compare
|
Rebased on current main (3.11). |
graingert
reviewed
Dec 23, 2021
Comment on lines
+194
to
+201
| def __call__(self, func): | ||
| @wraps(func) | ||
| async def inner(*args, **kwds): | ||
| async with self.__class__(self.func, self.args, self.kwds): | ||
| return await func(*args, **kwds) | ||
|
|
||
| return inner | ||
|
|
There was a problem hiding this comment.
this function is now redundant - support for asynccontextmanagers as decorators was added in #20516
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assumed at that an asynccontextmanager would some time be available in the stdlib when we first got async generators. Before it had been released I cooked up an internal version at facebook whiched mapped all the features of @contextmanager but as an async variant. This one feature seems to be missing from the stdlib.
I would like to stop using my version and just use the stdlib version, can we get this feature parity with contextmanager?
https://bugs.python.org/issue38415