Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-26103: Update the description of isdatadescriptor in inspect.rst #16645

Merged
merged 1 commit into from
Nov 15, 2019
Merged

bpo-26103: Update the description of isdatadescriptor in inspect.rst #16645

merged 1 commit into from
Nov 15, 2019

Conversation

hongweipeng
Copy link
Contributor

@hongweipeng hongweipeng commented Oct 8, 2019 •
edited by bedevere-bot
Loading

This is a complement to that PR #1959 . That PR may have forgotten to update the inspect.rst file.

https://bugs.python.org/issue26103

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 8, 2019
tirkarthi
tirkarthi approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as per linked PR and the implementation

cpython/Lib/inspect.py

Line 122 in ecbf35f

return hasattr(tp, "__set__") or hasattr(tp, "__delete__")
. Thanks.

@taleinat taleinat merged commit 84f2528 into python:master Nov 15, 2019
@bedevere-bot
Copy link

@taleinat: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @hongweipeng for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-17180 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Nov 15, 2019
@miss-islington @hongweipeng
Fix the description of isdatadescriptor in inspect.rst (GH-16645)
0b634df 
(cherry picked from commit 84f2528)

Co-authored-by: HongWeipeng <[email protected]>
@hongweipeng hongweipeng deleted the doc_inspect_isdatadescriptor branch November 16, 2019 00:48
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@hongweipeng
Fix the description of isdatadescriptor in inspect.rst (python#16645)
af787fe
@hongweipeng hongweipeng restored the doc_inspect_isdatadescriptor branch December 6, 2019 09:46
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@hongweipeng @shihai1991
Fix the description of isdatadescriptor in inspect.rst (python#16645)
6538a28
@hongweipeng hongweipeng deleted the doc_inspect_isdatadescriptor branch December 5, 2021 14:47
@aaronchall aaronchall mannequin mentioned this pull request Apr 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

@taleinat taleinat taleinat approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hongweipeng @bedevere-bot @miss-islington @taleinat @tirkarthi @brandtbucher @the-knights-who-say-ni