Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-34533: Remove all static state from _csv module #16078

Closed
wants to merge 3 commits into from
Closed

bpo-34533: Remove all static state from _csv module #16078

wants to merge 3 commits into from

Conversation

eduardo-elizondo
Copy link
Contributor

@eduardo-elizondo eduardo-elizondo commented Sep 13, 2019 •
edited
Loading

Add all the changes needed to make _csv compatible with PEP384 as well as removing all static state from it

https://bugs.python.org/issue34533

@eduardo-elizondo
Copy link
Contributor Author

Also, #8977 was trying to address this first but I couldn't manage to get a branch back from that so I just created a new PR

@encukou
Copy link
Member

encukou commented Sep 13, 2019

The PoC/WIP implementation of PEP 573 should do this plus also remove reliance PyState_FindModule.
I'll concentrate on that PEP rather than on reviewing this.

@eduardo-elizondo
Copy link
Contributor Author

Yup! PEP573 should be the long term solution for getting the module state in C Extensions. We can always go back and update this module once the PEP is finalized. On that note, I have a couple of comments/questions that I've been meaning to post in capi-sig about PEP573. I should prioritize that as well :-)

For now though, this should be ready to be merged as is (pending any in-line comments reviewers might have).

@eduardo-elizondo eduardo-elizondo changed the title bpo-34533: Make _csv compatible with PEP384 bpo-34533: Remove all static state from _csv module Sep 23, 2019
@ericsnowcurrently
Copy link
Member

Sorry, for the delay, @eduardo-elizondo. I plan on taking a look next Friday.

encukou added a commit to encukou/cpython that referenced this pull request May 19, 2020
@encukou @eduardo-elizondo
Use Eduardo's implementation for csv.dialect __reduce__
d1d1aa2 
See: python#16078
This is slightly nicer.

Co-authored-by: Eddie Elizondo <[email protected]>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jun 4, 2020
@encukou @eduardo-elizondo @shihai1991
Use Eduardo's implementation for csv.dialect __reduce__
e2b5649 
See: python#16078
This is slightly nicer.

Co-authored-by: Eddie Elizondo <[email protected]>
encukou added a commit to encukou/cpython that referenced this pull request Oct 20, 2020
@encukou @eduardo-elizondo @shihai1991
Remove static state from the _csv module
7b33be1 
Uses code from: python#16078

Co-authored-by: Marcel Plch <[email protected]>
Co-authored-by: Eddie Elizondo <[email protected]>
Co-authored-by: Hai Shi <[email protected]>
@encukou
Copy link
Member

encukou commented Oct 20, 2020

Here is my attempt: #22838

encukou added a commit to encukou/cpython that referenced this pull request Nov 10, 2020
@encukou @eduardo-elizondo @shihai1991
Remove static state from the _csv module
a2a0e6f 
Uses code from: python#16078

Co-authored-by: Marcel Plch <[email protected]>
Co-authored-by: Eddie Elizondo <[email protected]>
Co-authored-by: Hai Shi <[email protected]>
@encukou encukou mentioned this pull request Nov 10, 2020
Merged
encukou added a commit that referenced this pull request Dec 15, 2020
@encukou @eduardo-elizondo @shihai1991
bpo-14935: Remove static state from the _csv module (GH-23224)
6a02b38 
Uses code from: #16078

Co-authored-by: Marcel Plch <[email protected]>
Co-authored-by: Eddie Elizondo <[email protected]>
Co-authored-by: Hai Shi <[email protected]>
@encukou
Copy link
Member

encukou commented Dec 15, 2020

#23224, which includes this code, is now merged. Thank you for working on this!

@encukou encukou closed this Dec 15, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@encukou @eduardo-elizondo
@shihai1991 @adorilson
bpo-14935: Remove static state from the _csv module (pythonGH-23224)
94dc70f 
Uses code from: python#16078

Co-authored-by: Marcel Plch <[email protected]>
Co-authored-by: Eddie Elizondo <[email protected]>
Co-authored-by: Hai Shi <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request May 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eduardo-elizondo @encukou @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot