Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36409: Remove old plistlib API deprecated in 3.4 #15615

Merged
merged 4 commits into from
Sep 5, 2019
Merged

bpo-36409: Remove old plistlib API deprecated in 3.4 #15615

merged 4 commits into from
Sep 5, 2019

Conversation

bigfootjon
Copy link
Contributor

@bigfootjon bigfootjon commented Aug 30, 2019 •
edited by bedevere-bot
Loading

Also cleanup the documentation

https://bugs.python.org/issue36409

ronaldoussoren
ronaldoussoren requested changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good to me, except for one minor issue.

Doc/whatsnew/3.9.rst Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ronaldoussoren
ronaldoussoren requested changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more nit to pick...

I will merge once this is changed and the CI passes.

Doc/whatsnew/3.9.rst Outdated Show resolved Hide resolved
@bigfootjon
Copy link
Contributor Author

Thank you for the quick turnaround and tips @ronaldoussoren, I appreciate the help!

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ronaldoussoren: please review the changes made to this pull request.

ronaldoussoren
ronaldoussoren approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good to me.

@ronaldoussoren ronaldoussoren merged commit ce81a92 into python:master Sep 5, 2019
@ronaldoussoren
Copy link
Contributor

@bigfootjon Thanks for your patch!

@bigfootjon bigfootjon deleted the plistlib-remove-deprecated branch September 5, 2019 13:39
@bigfootjon bigfootjon mentioned this pull request Sep 7, 2019
Merged
ronaldoussoren pushed a commit that referenced this pull request Sep 9, 2019
@bigfootjon @ronaldoussoren
bpo-38053 Update documentation for plistlib (GH-15727)
24b11b8 
* Update documentation for plistlib

-  Update "Mac OS X" to "Apple" since plists are used more widely than just macOS
-  Re-add the UID class documentation (oops, removed in GH-15615)
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@bigfootjon @lisroach
bpo-36409: Remove old plistlib API deprecated in 3.4 (pythonGH-15615)
b3c9006 
* Remove implementation for old plistlib API deprecated in 3.4
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@bigfootjon @DinoV
bpo-36409: Remove old plistlib API deprecated in 3.4 (pythonGH-15615)
913ed61 
* Remove implementation for old plistlib API deprecated in 3.4
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@bigfootjon @websurfer5
bpo-36409: Remove old plistlib API deprecated in 3.4 (pythonGH-15615)
27255e5 
* Remove implementation for old plistlib API deprecated in 3.4
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@bigfootjon @websurfer5
bpo-38053 Update documentation for plistlib (pythonGH-15727)
729ad13 
* Update documentation for plistlib

-  Update "Mac OS X" to "Apple" since plists are used more widely than just macOS
-  Re-add the UID class documentation (oops, removed in pythonGH-15615)
@justvanrossum
Copy link

justvanrossum commented Oct 31, 2020 •
edited
Loading

It appears the removal of the use_builtin_types argument to load() was not preceded by a deprecation phase. That makes this a rather hard breaking change. See for example unified-font-object/ufoNormalizer#73 and downstream issues.

This was referenced Jan 3, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldoussoren ronaldoussoren ronaldoussoren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bigfootjon @bedevere-bot @ronaldoussoren @justvanrossum @the-knights-who-say-ni