-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-36409: Remove old plistlib API deprecated in 3.4 #15615
bpo-36409: Remove old plistlib API deprecated in 3.4 #15615
Conversation
Also cleanup the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch looks good to me, except for one minor issue.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more nit to pick...
I will merge once this is changed and the CI passes.
Thank you for the quick turnaround and tips @ronaldoussoren, I appreciate the help! I have made the requested changes; please review again |
Thanks for making the requested changes! @ronaldoussoren: please review the changes made to this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch looks good to me.
@bigfootjon Thanks for your patch! |
* Remove implementation for old plistlib API deprecated in 3.4
* Remove implementation for old plistlib API deprecated in 3.4
* Remove implementation for old plistlib API deprecated in 3.4
* Update documentation for plistlib - Update "Mac OS X" to "Apple" since plists are used more widely than just macOS - Re-add the UID class documentation (oops, removed in pythonGH-15615)
It appears the removal of the |
Also cleanup the documentation
https://bugs.python.org/issue36409