Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-15999: Accept arbitrary values for boolean parameters. #15609

Merged
merged 10 commits into from
Dec 3, 2022
Merged

bpo-15999: Accept arbitrary values for boolean parameters. #15609

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f0fdd30
bpo-15999: Accept arbitrary values for boolean parameters.
serhiy-storchaka Aug 30, 2019
cde16f5
Fix tests.
serhiy-storchaka Aug 31, 2019
d69a95b
Merge branch 'master' into accept-bool
serhiy-storchaka Aug 31, 2019
0f7d5c3
update the news entry wording.
gpshead Sep 9, 2019
8762601
update the whatsnew wording
gpshead Sep 9, 2019
c74f20a
Merge branch 'master' into accept-bool
serhiy-storchaka Sep 10, 2019
5aab3dc
Merge branch 'master' into accept-bool
serhiy-storchaka Aug 26, 2020
0b5c307
Merge branch 'main' into accept-bool
serhiy-storchaka Dec 3, 2022
20eafa5
Add more changes.
serhiy-storchaka Dec 3, 2022
c9b2d1c
Rephrased the news entry.
gpshead Dec 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Doc/whatsnew/3.9.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@ Other Language Changes
ignored for empty strings.
(Contributed by Victor Stinner in :issue:`37388`.)

* All builtin and extension functions and methods now accept arguments of any
type instead of just :class:`bool` and :class:`int` for boolean parameters.
(Contributed by Serhiy Storchaka in :issue:`15999`.)


New Modules
===========
Expand Down
4 changes: 0 additions & 4 deletions Lib/test/test_itertools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,10 +695,6 @@ def test_cycle_setstate(self):
c.__setstate__((tuple('defg'), 0))
take(20, c)

# The second argument in the setstate tuple must be an int
with self.assertRaises(TypeError):
cycle('defg').__setstate__((list('abcdefg'), 'x'))

self.assertRaises(TypeError, cycle('').__setstate__, ())
self.assertRaises(TypeError, cycle('').__setstate__, ([],))

Expand Down
6 changes: 0 additions & 6 deletions Lib/test/test_posix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1589,12 +1589,6 @@ def test_resetids(self):
)
self.assertEqual(os.waitpid(pid, 0), (pid, 0))

def test_resetids_wrong_type(self):
with self.assertRaises(TypeError):
self.spawn_func(sys.executable,
[sys.executable, "-c", "pass"],
os.environ, resetids=None)

def test_setpgroup(self):
pid = self.spawn_func(
sys.executable,
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2019-08-30-10-48-53.bpo-15999.QqsRRi.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
All built-in functions now accept arguments of any type instead of just
``bool`` and ``int`` for boolean parameters.
52 changes: 26 additions & 26 deletions Modules/_codecsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,14 +253,14 @@ _codecs_escape_encode_impl(PyObject *module, PyObject *data,
_codecs.utf_7_decode
data: Py_buffer
errors: str(accept={str, NoneType}) = NULL
final: bool(accept={int}) = False
final: bool = False
/
[clinic start generated code]*/

static PyObject *
_codecs_utf_7_decode_impl(PyObject *module, Py_buffer *data,
const char *errors, int final)
/*[clinic end generated code: output=0cd3a944a32a4089 input=2d94a5a1f170c8ae]*/
/*[clinic end generated code: output=0cd3a944a32a4089 input=b5fba42f7922078d]*/
{
Py_ssize_t consumed = data->len;
PyObject *decoded = PyUnicode_DecodeUTF7Stateful(data->buf, data->len,
Expand All @@ -273,14 +273,14 @@ _codecs_utf_7_decode_impl(PyObject *module, Py_buffer *data,
_codecs.utf_8_decode
data: Py_buffer
errors: str(accept={str, NoneType}) = NULL
final: bool(accept={int}) = False
final: bool = False
/
[clinic start generated code]*/

static PyObject *
_codecs_utf_8_decode_impl(PyObject *module, Py_buffer *data,
const char *errors, int final)
/*[clinic end generated code: output=10f74dec8d9bb8bf input=1ea6c21492e8bcbe]*/
/*[clinic end generated code: output=10f74dec8d9bb8bf input=043c24dea5ec9c7c]*/
{
Py_ssize_t consumed = data->len;
PyObject *decoded = PyUnicode_DecodeUTF8Stateful(data->buf, data->len,
Expand All @@ -293,14 +293,14 @@ _codecs_utf_8_decode_impl(PyObject *module, Py_buffer *data,
_codecs.utf_16_decode
data: Py_buffer
errors: str(accept={str, NoneType}) = NULL
final: bool(accept={int}) = False
final: bool = False
/
[clinic start generated code]*/

static PyObject *
_codecs_utf_16_decode_impl(PyObject *module, Py_buffer *data,
const char *errors, int final)
/*[clinic end generated code: output=783b442abcbcc2d0 input=2ba128c28ea0bb40]*/
/*[clinic end generated code: output=783b442abcbcc2d0 input=b4bb29bf325ed922]*/
{
int byteorder = 0;
/* This is overwritten unless final is true. */
Expand All @@ -315,14 +315,14 @@ _codecs_utf_16_decode_impl(PyObject *module, Py_buffer *data,
_codecs.utf_16_le_decode
data: Py_buffer
errors: str(accept={str, NoneType}) = NULL
final: bool(accept={int}) = False
final: bool = False
/
[clinic start generated code]*/

static PyObject *
_codecs_utf_16_le_decode_impl(PyObject *module, Py_buffer *data,
const char *errors, int final)
/*[clinic end generated code: output=899b9e6364379dcd input=43aeb8b0461cace5]*/
/*[clinic end generated code: output=899b9e6364379dcd input=83c12efe12fb4260]*/
{
int byteorder = -1;
/* This is overwritten unless final is true. */
Expand All @@ -337,14 +337,14 @@ _codecs_utf_16_le_decode_impl(PyObject *module, Py_buffer *data,
_codecs.utf_16_be_decode
data: Py_buffer
errors: str(accept={str, NoneType}) = NULL
final: bool(accept={int}) = False
final: bool = False
/
[clinic start generated code]*/

static PyObject *
_codecs_utf_16_be_decode_impl(PyObject *module, Py_buffer *data,
const char *errors, int final)
/*[clinic end generated code: output=49f6465ea07669c8 input=339e554c804f34b2]*/
/*[clinic end generated code: output=49f6465ea07669c8 input=7a1ee86e2e48b3e4]*/
{
int byteorder = 1;
/* This is overwritten unless final is true. */
Expand All @@ -367,14 +367,14 @@ _codecs.utf_16_ex_decode
data: Py_buffer
errors: str(accept={str, NoneType}) = NULL
byteorder: int = 0
final: bool(accept={int}) = False
final: bool = False
/
[clinic start generated code]*/

static PyObject *
_codecs_utf_16_ex_decode_impl(PyObject *module, Py_buffer *data,
const char *errors, int byteorder, int final)
/*[clinic end generated code: output=0f385f251ecc1988 input=3201aeddb9636889]*/
/*[clinic end generated code: output=0f385f251ecc1988 input=955e8d9cd5dfe9f7]*/
{
/* This is overwritten unless final is true. */
Py_ssize_t consumed = data->len;
Expand All @@ -391,14 +391,14 @@ _codecs_utf_16_ex_decode_impl(PyObject *module, Py_buffer *data,
_codecs.utf_32_decode
data: Py_buffer
errors: str(accept={str, NoneType}) = NULL
final: bool(accept={int}) = False
final: bool = False
/
[clinic start generated code]*/

static PyObject *
_codecs_utf_32_decode_impl(PyObject *module, Py_buffer *data,
const char *errors, int final)
/*[clinic end generated code: output=2fc961807f7b145f input=155a5c673a4e2514]*/
/*[clinic end generated code: output=2fc961807f7b145f input=624fcb504074bab6]*/
{
int byteorder = 0;
/* This is overwritten unless final is true. */
Expand All @@ -413,14 +413,14 @@ _codecs_utf_32_decode_impl(PyObject *module, Py_buffer *data,
_codecs.utf_32_le_decode
data: Py_buffer
errors: str(accept={str, NoneType}) = NULL
final: bool(accept={int}) = False
final: bool = False
/
[clinic start generated code]*/

static PyObject *
_codecs_utf_32_le_decode_impl(PyObject *module, Py_buffer *data,
const char *errors, int final)
/*[clinic end generated code: output=ec8f46b67a94f3e6 input=7baf061069e92d3b]*/
/*[clinic end generated code: output=ec8f46b67a94f3e6 input=846d386727d4e74a]*/
{
int byteorder = -1;
/* This is overwritten unless final is true. */
Expand All @@ -435,14 +435,14 @@ _codecs_utf_32_le_decode_impl(PyObject *module, Py_buffer *data,
_codecs.utf_32_be_decode
data: Py_buffer
errors: str(accept={str, NoneType}) = NULL
final: bool(accept={int}) = False
final: bool = False
/
[clinic start generated code]*/

static PyObject *
_codecs_utf_32_be_decode_impl(PyObject *module, Py_buffer *data,
const char *errors, int final)
/*[clinic end generated code: output=ff82bae862c92c4e input=b182026300dae595]*/
/*[clinic end generated code: output=ff82bae862c92c4e input=461cf256c580e397]*/
{
int byteorder = 1;
/* This is overwritten unless final is true. */
Expand All @@ -465,14 +465,14 @@ _codecs.utf_32_ex_decode
data: Py_buffer
errors: str(accept={str, NoneType}) = NULL
byteorder: int = 0
final: bool(accept={int}) = False
final: bool = False
/
[clinic start generated code]*/

static PyObject *
_codecs_utf_32_ex_decode_impl(PyObject *module, Py_buffer *data,
const char *errors, int byteorder, int final)
/*[clinic end generated code: output=6bfb177dceaf4848 input=7b9c2cb819fb237a]*/
/*[clinic end generated code: output=6bfb177dceaf4848 input=c11c2c8386296376]*/
{
Py_ssize_t consumed = data->len;
PyObject *decoded = PyUnicode_DecodeUTF32Stateful(data->buf, data->len,
Expand Down Expand Up @@ -577,14 +577,14 @@ _codecs_charmap_decode_impl(PyObject *module, Py_buffer *data,
_codecs.mbcs_decode
data: Py_buffer
errors: str(accept={str, NoneType}) = NULL
final: bool(accept={int}) = False
final: bool = False
/
[clinic start generated code]*/

static PyObject *
_codecs_mbcs_decode_impl(PyObject *module, Py_buffer *data,
const char *errors, int final)
/*[clinic end generated code: output=39b65b8598938c4b input=b5f2fe568f311297]*/
/*[clinic end generated code: output=39b65b8598938c4b input=c065a414c4469c8e]*/
{
Py_ssize_t consumed = data->len;
PyObject *decoded = PyUnicode_DecodeMBCSStateful(data->buf, data->len,
Expand All @@ -596,14 +596,14 @@ _codecs_mbcs_decode_impl(PyObject *module, Py_buffer *data,
_codecs.oem_decode
data: Py_buffer
errors: str(accept={str, NoneType}) = NULL
final: bool(accept={int}) = False
final: bool = False
/
[clinic start generated code]*/

static PyObject *
_codecs_oem_decode_impl(PyObject *module, Py_buffer *data,
const char *errors, int final)
/*[clinic end generated code: output=da1617612f3fcad8 input=278709bcfd374a9c]*/
/*[clinic end generated code: output=da1617612f3fcad8 input=00a4294837793f55]*/
{
Py_ssize_t consumed = data->len;
PyObject *decoded = PyUnicode_DecodeCodePageStateful(CP_OEMCP,
Expand All @@ -616,14 +616,14 @@ _codecs.code_page_decode
codepage: int
data: Py_buffer
errors: str(accept={str, NoneType}) = NULL
final: bool(accept={int}) = False
final: bool = False
/
[clinic start generated code]*/

static PyObject *
_codecs_code_page_decode_impl(PyObject *module, int codepage,
Py_buffer *data, const char *errors, int final)
/*[clinic end generated code: output=53008ea967da3fff input=51f6169021c68dd5]*/
/*[clinic end generated code: output=53008ea967da3fff input=6b274299b45ced3c]*/
{
Py_ssize_t consumed = data->len;
PyObject *decoded = PyUnicode_DecodeCodePageStateful(codepage,
Expand Down
Loading