bpo-36231: Support building on macOS without /usr/include #13773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ned-deily for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7. |
|
Sorry, @ned-deily, I could not cleanly backport this to |
|
Sorry @ned-deily, I had trouble checking out the |
|
ned-deily
added a commit
to ned-deily/cpython
that referenced
this pull request
Jun 18, 2019
|
GH-14208 is a backport of this pull request to the 3.7 branch. |
ned-deily
added a commit
that referenced
this pull request
Jun 18, 2019
ned-deily
added a commit
to ned-deily/cpython
that referenced
this pull request
Jun 20, 2019
|
GH-14256 is a backport of this pull request to the 2.7 branch. |
ned-deily
added a commit
that referenced
this pull request
Jun 20, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple has been trying to discourage the use of installing and compiling with system header files in
/usr/include. Instead, the favored approach is to use header files from within a macOS SDK. For the most part, the Apple-supplied toolchain handles this transparently as long as the toolchain is doing the searching for header files. Unfortunately, the top-levelsetup.pyused to build the Python interpreter does some searching for various header files on its own and, with the removal in macOS 10.14 of the option to install system headers, the Python build may now fail to build several standard library modules that depend on third-party libraries shipped with macOS, for example, sqlite3.The search behavior of the toolchain is also conditioned by the setting of various environment variables or by the use of
xcrun, i.e. it is possible to change SDK locations at build time (man xcrunhas more information). And non-Apple compilers might be in use soxcrunmight not give the correct results. If an SDK is not explicitly specified at./configuretime or viaCFLAGS, the solution used here is to rely on using the-voutput from the compiler preprocessor to find the include file paths that are actually being used (this technique is used elsewhere insetup.py) and from them derive an SDK root forsetup.pyto use in its searches. There is a bit of a bootstrap issue in that much of the standard library is not yet available whensetup.pyis running (it's trying to build the non-builtin modules) so the code here has to make do with a few hacks.https://bugs.python.org/issue36231