Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119182: Complete PyUnicodeWriter documentation #127607

Merged
merged 1 commit into from
Dec 5, 2024
Merged

gh-119182: Complete PyUnicodeWriter documentation #127607

merged 1 commit into from
Dec 5, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 4, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added the docs Documentation in the Doc dir label Dec 4, 2024
@bedevere-app bedevere-app bot mentioned this pull request Dec 4, 2024
Closed
@vstinner
Copy link
Member Author

vstinner commented Dec 4, 2024

cc @pitrou @skirpichev

@skirpichev skirpichev self-requested a review December 5, 2024 04:41
skirpichev
skirpichev approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

But, perhaps, you could move sentence "The instance must be destroyed by ... or ..." to the PyUnicodeWriter_Create() docs.

@vstinner vstinner merged commit 1ef6e8c into python:main Dec 5, 2024
36 checks passed
@vstinner vstinner deleted the writer_doc branch December 5, 2024 09:37
@vstinner
Copy link
Member Author

vstinner commented Dec 5, 2024

Merged, thanks for reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@skirpichev skirpichev skirpichev approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @skirpichev @kumaraditya303 @StanFromIreland