gh-126399 add test of turtle module's RawTurtle.clone() #127189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_turtle.TestRawTurtle.test_clone(self):
assert the last item in the items list of the cloned turtle is correct.
more specifically, the item should be the same as the currentLineItem of the cloned turtle.
also, the currentLineItem of the original turtle should not be in the items list of the cloned turtle.
test_turtle.TestRawTurtle.setUp(self):
skip test if the RawTurtle cannot be initialized because tk/tcl is not supported
edited spacings
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding issue proposes a modification on turtle module's RawTurtle.clone() function.
Specifically, items of cloned RawTurtle object to have its own currentLineItem, and not the currentLineItem of the original.
This test checks the items of cloned RawTurtle to meet the proposal.
The test is expected to fail without #126401 and pass with it.
The test is skipped when Tk/Tcl is not supported.