Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-127082: Replace "Windows only: ..." with the .. availability:: Windows directive in ctypes doc. #127099

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-127082: Replace "Windows only: ..." with the .. availability:: Windows directive in ctypes doc. #127099

wants to merge 2 commits into from
+66 −35

Conversation

junkmd
Copy link
Contributor

@junkmd junkmd commented Nov 21, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added the docs Documentation in the Doc dir label Nov 21, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 21, 2024
Open
vstinner
vstinner approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it would be better to not reformat paragraphs to keep the change as small as possible: only change the first line of the modified paragraphs.

Eclips4
Eclips4 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 to Victor's words.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
awaiting merge docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@junkmd @vstinner @Eclips4