-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126256: Update time.rst to use the same clock as instead of the same clock than #126257
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than` The time documentation uses the same clock than time.monotonic instead of the same clock as time.monotonic, which is grammatically false. This PR fixes changes two instances of `the same clock than` to `the same clock as`.
pythongh-126256: Update time.rst to use `the same clock as` instead of `the same clock than`
bedevere-app
bot
added
docs
Documentation in the Doc dir
skip news
awaiting review
labels
Oct 31, 2024
sobolevn
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Congrats on your first PR!
sobolevn
added
needs backport to 3.12
bug and security fixes
needs backport to 3.13
bugs and security fixes
labels
Oct 31, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 31, 2024
…the same clock than (pythonGH-126257) Update time.rst to use `the same clock as` instead of `the same clock than` The time documentation uses the same clock than time.monotonic instead of the same clock as time.monotonic, which is grammatically false. This PR fixes changes two instances of `the same clock than` to `the same clock as`. (cherry picked from commit d0abd0b826cfa574d1515c6f8459c9901939388f) Co-authored-by: Alperen Keleş <[email protected]>
GH-126258 is a backport of this pull request to the 3.13 branch. |
sobolevn
pushed a commit
that referenced
this pull request
Oct 31, 2024
… the same clock than (GH-126257) (#126258) gh-126256: Update time.rst to use the same clock as instead of the same clock than (GH-126257) Update time.rst to use `the same clock as` instead of `the same clock than` The time documentation uses the same clock than time.monotonic instead of the same clock as time.monotonic, which is grammatically false. This PR fixes changes two instances of `the same clock than` to `the same clock as`. (cherry picked from commit d0abd0b) Co-authored-by: Alperen Keleş <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time documentation uses the same clock than time.monotonic instead of the same clock as time.monotonic, which is grammatically false. This PR fixes changes two instances of the same clock than to the same clock as.
#126256
time.rst
usesthe same than
, which is grammatically incorrect #126256📚 Documentation preview 📚: https://cpython-previews--126257.org.readthedocs.build/