Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect indentation in importlib.metadata.rst #126189

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented Oct 30, 2024

This code was breaking lines and splitting translation strings

How it was:

image

After this fix:

image


📚 Documentation preview 📚: https://cpython-previews--126189.org.readthedocs.build/

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rffontenelle!

@willingc willingc added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Oct 30, 2024
@willingc
Copy link
Contributor

Thanks for the review too @picnixz

@willingc willingc merged commit 6f512c6 into python:main Oct 30, 2024
46 checks passed
@miss-islington-app
Copy link

Thanks @rffontenelle for the PR, and @willingc for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 30, 2024
(cherry picked from commit 6f512c6)

Co-authored-by: Rafael Fontenelle <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 30, 2024
(cherry picked from commit 6f512c6)

Co-authored-by: Rafael Fontenelle <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 30, 2024

GH-126193 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 30, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 30, 2024

GH-126194 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 30, 2024
@rffontenelle rffontenelle deleted the patch-6 branch October 30, 2024 17:48
willingc pushed a commit that referenced this pull request Oct 30, 2024
GH-126193)

Fix incorrect indentation in importlib.metadata.rst (GH-126189)
(cherry picked from commit 6f512c6)

Co-authored-by: Rafael Fontenelle <[email protected]>
willingc pushed a commit that referenced this pull request Oct 30, 2024
GH-126194)

Fix incorrect indentation in importlib.metadata.rst (GH-126189)
(cherry picked from commit 6f512c6)

Co-authored-by: Rafael Fontenelle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants