gh-124218: Use per-thread reference counting for globals and builtins #125713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iltins Use per-thread refcounting for the reference from function objects to the globals and builtins dictionaries.
colesbury
requested review from
ericsnowcurrently,
methane and
markshannon
as code owners
mpage
reviewed
Oct 19, 2024
Yhg1s
reviewed
Oct 19, 2024
* Add some code comments about _Py_INCREF_TYPE/CODE/DICT * Fix typo * Move size check to `_PyDict_EnablePerThreadRefcounting`
Yhg1s
approved these changes
Oct 21, 2024
mpage
approved these changes
Oct 21, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…iltins (python#125713) Use per-thread refcounting for the reference from function objects to the globals and builtins dictionaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use per-thread refcounting for the reference from function objects to the globals and builtins dictionaries.
There's still one remaining bottleneck in
_PyEval_BuiltinsFromGlobals, which temporarily modifies the bulitins dictionary reference count before returning a borrowed reference.