Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crash #125218

Closed
wants to merge 4 commits into from
Closed

gh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crash #125218

wants to merge 4 commits into from

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Oct 9, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 9, 2024
Closed
@mdboom mdboom changed the title gh-125217: Turn off optimization are _PyEval_EvalFrameDefault to avoid MSVC crash gh-125217: Turn off optimization around_PyEval_EvalFrameDefault to avoid MSVC crash Oct 9, 2024
@mdboom mdboom marked this pull request as draft October 10, 2024 15:47
@mdboom
Copy link
Contributor Author

mdboom commented Oct 11, 2024

Closing is this does not resolve the issue.

@mdboom mdboom closed this Oct 11, 2024
@neonene
Copy link
Contributor

neonene commented Oct 14, 2024

Have you already tried _Py_JIT (underscored)? I have an alternative, but I prefer this.

@mdboom
Copy link
Contributor Author

mdboom commented Oct 14, 2024

Have you already tried _Py_JIT (underscored)? I have an alternative, but I prefer this.

Thanks, @neonene. Indeed, that was just a typo on my part and correcting it does work around the compiler crash. Github wouldn't let me re-open this but I have a new PR here: #125477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdboom @neonene