gh-124218: Use per-thread refcounts for code objects #125216
Conversation
Use per-thread refcounting for the reference from function objects to their corresponding code object. This can be a source of contention when frequently creating nested functions. Deferred refcounting alone isn't a great fit here because these references are on the heap and may be modified by other libraries.
colesbury
added
skip news
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 018b2a1 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
colesbury
requested review from
ericsnowcurrently and
markshannon
as code owners
|
This seems like we are adding more code, rather than reusing the existing code for per-thread refcounts already in existence for classes. |
|
It is factored out and reusing existing code. That's why What concretely would you like changed? |
|
Quite a lot of code is being added to pycore_object.h, but I don't see code being removed from typeobject.c or wherever the code for per-thread reference counts for classes is. |
|
What would you like to see changed?
|
| static inline void | ||
| _Py_DECREF_CODE(PyCodeObject *co) | ||
| { | ||
| _Py_THREAD_DECREF_OBJECT((PyObject *)co, co->_co_unique_id); |
There was a problem hiding this comment.
assert that co is a code object.
There was a problem hiding this comment.
co is statically a PyCodeObject *. We don't typically dynamically check the type when we have the static type (e.g., in PyCode_Addr2Line)
There was a problem hiding this comment.
I meant it to be protect against incorrect casts, anyways it's minor.
| static inline void | ||
| _Py_INCREF_CODE(PyCodeObject *co) | ||
| { | ||
| _Py_THREAD_INCREF_OBJECT((PyObject *)co, co->_co_unique_id); |
There was a problem hiding this comment.
Same add assert to check it is codeobject
Co-authored-by: Kumar Aditya <[email protected]>
|
!buildbot AMD64 Fedora Stable Refleaks |
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit 7ad129b 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
Co-authored-by: mpage <[email protected]>
Use per-thread refcounting for the reference from function objects to their corresponding code object. This can be a source of contention when frequently creating nested functions. Deferred refcounting alone isn't a great fit here because these references are on the heap and may be modified by other libraries.
We will still need to address the globals and builtins dictionaries in a similar way.