[3.10] gh-89452: GHA: Set --with-dbmliborder to avoid issues with homebrew's gdbm 1.24 #125112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th homebrew's gdbm 1.24 Per python#89452 (comment), the issue is fixed in configure for 3.11+, and > For older Python versions, the workaround is to build with: > > ./configure --with-dbmliborder=gdbm:ndbm We need this workaround in GitHub Actions, otherwise the tests fail.
This was referenced Oct 8, 2024
|
@pablogsal @ambv, given #89452 (comment), does this look reasonable to you, as a workaround for a buildsystem/homebrew incompatibility which was fixed better in 3.11+? If so, I'll also backport to 3.9 and update the Devguide homebrew instructions. |
|
Makes sense to me. |
|
Sorry, @encukou and @ambv, I could not cleanly backport this to |
encukou
added a commit
to encukou/cpython
that referenced
this pull request
Oct 9, 2024
…h homebrew's gdbm 1.24 (pythonGH-125112) Per https://github.com/python/cpython/issues/89452GH-issuecomment-1116329316, the issue is fixed in configure for 3.11+, and > For older Python versions, the workaround is to build with: > > ./configure --with-dbmliborder=gdbm:ndbm We need this workaround in GitHub Actions, otherwise the tests fail. (cherry picked from commit 850189a)
|
GH-125176 is a backport of this pull request to the 3.9 branch. |
ambv
added a commit
that referenced
this pull request
Oct 9, 2024
…brew's gdbm 1.24 (GH-125112) (#125176) Per https://github.com/python/cpython/issues/89452GH-issuecomment-1116329316, the issue is fixed in configure for 3.11+, and > For older Python versions, the workaround is to build with: > > ./configure --with-dbmliborder=gdbm:ndbm We need this workaround in GitHub Actions, otherwise the tests fail. (cherry picked from commit 850189a) Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #89452 (comment), the issue is fixed in configure for 3.11+, and
We need this workaround in GitHub Actions, otherwise the tests fail.
See also: gh-105304