Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-124102: Update internal PCbuild docs and correct WiX registry #124784

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

Wulian233
Copy link
Contributor

@Wulian233 Wulian233 commented Sep 30, 2024

skip news
@zooba I got something wrong in the previous PR

  • Corrected the incorrect information in the previous PR
2024-09-30 182656
  • Fixed the incorrect WiX 3.14 registry.

Tools/msi/wix.props Outdated Show resolved Hide resolved
Doc/using/windows.rst Outdated Show resolved Hide resolved
@Wulian233 Wulian233 requested a review from zooba October 4, 2024 01:38
@Wulian233
Copy link
Contributor Author

@zooba Could you please review this again? I have already resolved the issues mentioned :)

@Wulian233 Wulian233 changed the title gh-124102: Update internal documentation under PCbuild, so it now correctly states that Windows Dependency Information gh-124102: Update internal PCbuild docs and correct WiX registry Oct 14, 2024
@zooba zooba merged commit cda0ec8 into python:main Oct 18, 2024
35 checks passed
@Wulian233 Wulian233 deleted the pcbuild branch October 18, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants