[3.13] gh-121735: Fix module-adjacent references in zip files (GH-123037) #123986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…H-123037) * pythongh-116608: Apply style and compatibility changes from importlib_metadata. * pythongh-121735: Ensure module-adjacent resources are loadable from a zipfile. * pythongh-121735: Allow all modules to be processed by the ZipReader. * Add blurb * Remove update-zips script, unneeded. * Remove unnecessary references to removed static fixtures. * Remove zipdata fixtures, unused. (cherry picked from commit ba687d9) Co-authored-by: Jason R. Coombs <[email protected]>
miss-islington
requested review from
jaraco,
warsaw,
FFY00,
brettcannon,
ericsnowcurrently and
ncoghlan
as code owners
This was referenced Sep 12, 2024
|
Note that I cherry-picked #123995 to address build bot failures introduced by the original change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Un-deprecate functional API for importlib resources & add subdirectory support #116608: Apply style and compatibility changes from importlib_metadata.
Can't open orphan path on bare importlib.resources.files() under zipapp #121735: Ensure module-adjacent resources are loadable from a zipfile.
Can't open orphan path on bare importlib.resources.files() under zipapp #121735: Allow all modules to be processed by the ZipReader.
Add blurb
Remove update-zips script, unneeded.
Remove unnecessary references to removed static fixtures.
Remove zipdata fixtures, unused.
(cherry picked from commit ba687d9)
Co-authored-by: Jason R. Coombs [email protected]