Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-123458: Skip SBOM generation if no git repository is detected #123507

Merged
merged 1 commit into from
Sep 2, 2024
Merged

gh-123458: Skip SBOM generation if no git repository is detected #123507

merged 1 commit into from
Sep 2, 2024

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Aug 30, 2024 •
edited by bedevere-app bot
Loading

This skips SBOM generation if there's no git repository in the source tree.

@bedevere-app bedevere-app bot mentioned this pull request Aug 30, 2024
Closed
@sethmlarson sethmlarson requested a review from zooba August 30, 2024 14:32
zooba
zooba approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk hugovk merged commit db42934 into python:main Sep 2, 2024
44 checks passed
@hugovk hugovk added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Sep 2, 2024
@miss-islington-app
Copy link

Thanks @sethmlarson for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @sethmlarson for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2024
@sethmlarson @miss-islington
pythongh-123458: Skip SBOM generation if no git repository is detected (
df7e308 
pythonGH-123507)

(cherry picked from commit db42934)

Co-authored-by: Seth Michael Larson <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 2, 2024

GH-123615 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2024
@sethmlarson @miss-islington
pythongh-123458: Skip SBOM generation if no git repository is detected (
8033804 
pythonGH-123507)

(cherry picked from commit db42934)

Co-authored-by: Seth Michael Larson <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 2, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 2, 2024

GH-123616 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 2, 2024
Yhg1s pushed a commit that referenced this pull request Sep 2, 2024
@miss-islington @sethmlarson
[3.13] gh-123458: Skip SBOM generation if no git repository is detect…
f812423 
…ed (GH-123507) (#123616)

gh-123458: Skip SBOM generation if no git repository is detected (GH-123507)
(cherry picked from commit db42934)

Co-authored-by: Seth Michael Larson <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 2, 2024
@miss-islington @sethmlarson
[3.12] gh-123458: Skip SBOM generation if no git repository is detect…
ff4ad2e 
…ed (GH-123507) (#123615)

gh-123458: Skip SBOM generation if no git repository is detected (GH-123507)
(cherry picked from commit db42934)

Co-authored-by: Seth Michael Larson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sethmlarson @zooba @hugovk