Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-120426: Reword the glossary term "immortal" #123191

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

encukou
Copy link
Member

@encukou encukou commented Aug 21, 2024

This makes it clearer that immortality is an implementation detail, and PEP-683 is a historical document.


📚 Documentation preview 📚: https://cpython-previews--123191.org.readthedocs.build/

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@encukou encukou added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Aug 27, 2024
@encukou encukou merged commit 6754566 into python:main Aug 27, 2024
31 checks passed
@miss-islington-app
Copy link

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@encukou encukou deleted the reword-immortal branch August 27, 2024 11:38
@miss-islington-app
Copy link

Sorry, @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6754566a51a5706e8c9da0094b892113311ba20c 3.13

@miss-islington-app
Copy link

Sorry, @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6754566a51a5706e8c9da0094b892113311ba20c 3.12

encukou added a commit to encukou/cpython that referenced this pull request Aug 30, 2024
Reword the glossary term "immortal", mark it as an implementation detail

(cherry picked from commit 6754566)
@bedevere-app
Copy link

bedevere-app bot commented Aug 30, 2024

GH-123491 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 30, 2024
Yhg1s pushed a commit that referenced this pull request Sep 2, 2024
…23491)

gh-120426: Reword the glossary term "immortal" (GH-123191)

Reword the glossary term "immortal", mark it as an implementation detail

(cherry picked from commit 6754566)
encukou added a commit to encukou/cpython that referenced this pull request Sep 3, 2024
…3191) (python#123491)

Add the glossary term "immortal", mark it as an implementation detail

(cherry picked from commit 6754566)
(cherry picked from commit 1af74fa)

(Unlike the original commits, this adds the entire entry.)
ambv pushed a commit that referenced this pull request Sep 6, 2024
…3491) (#123636)

Add the glossary term "immortal", mark it as an implementation detail

(cherry picked from commit 6754566)
(cherry picked from commit 1af74fa)

(Unlike the original commits, this adds the entire entry.)
@picnixz picnixz removed the needs backport to 3.12 bug and security fixes label Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants