Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] gh-116608: Apply style and compatibility changes from importlib_resources. (GH-123028) #123051

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 15, 2024

…_metadata. (pythonGH-123028)

(cherry picked from commit e913d2c)

Co-authored-by: Jason R. Coombs <[email protected]>
@jaraco jaraco changed the title [3.13] gh-116608: Apply style and compatibility changes from importlib_metadata. (GH-123028) [3.13] gh-116608: Apply style and compatibility changes from importlib_resources. (GH-123028) Aug 15, 2024
@jaraco jaraco enabled auto-merge (squash) August 15, 2024 19:34
@jaraco jaraco merged commit 5ac14ee into python:3.13 Aug 15, 2024
36 checks passed
@encukou
Copy link
Member

encukou commented Aug 16, 2024

I don't think this is important enough for a release candidate fix.
Are you aware that in the RC phase, all changes need to be reviewed?

@jaraco
Copy link
Member

jaraco commented Aug 16, 2024

Oops. I wasn't aware that we were in RC phase. I guess I'd lost track of time.

I was considering this change blocking for #123037, not because the changes interact, but because when syncing the changes from importlib_resources@cpython to cpython@main, the files get copied wholesale (there's no VCS tracking), and these changes needed to be applied to get those codebases aligned.

I'll revert this change and then re-submit the backport to be blocked on cutting of 3.13.0.

jaraco added a commit to jaraco/cpython that referenced this pull request Aug 16, 2024
… from importlib_resources. (pythonGH-123028) (python#123051)"

This reverts commit 5ac14ee.

This commit should be re-applied after 3.13.0 final.
jaraco added a commit to jaraco/cpython that referenced this pull request Aug 16, 2024
…nd compatibility changes from importlib_resources. (pythonGH-123028) (python#123051)"

This reverts commit 5ac14ee.

This commit should be re-applied after 3.13.0 final.
@bedevere-app
Copy link

bedevere-app bot commented Aug 16, 2024

GH-123072 is a backport of this pull request to the 3.13 branch.

@jaraco
Copy link
Member

jaraco commented Aug 16, 2024

#123072 is the revert.

jaraco added a commit to jaraco/cpython that referenced this pull request Aug 16, 2024
…pythongh-116608: Apply style and compatibility changes from importlib_resources. (pythonGH-123028) (python#123051)""

This reverts commit 0a058bc.
@jaraco
Copy link
Member

jaraco commented Aug 16, 2024

And #123074 is the revert revert (re-apply) for after 3.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants