Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] gh-120104: IDLE: Fix padding in config and search dialogs (GH-120107) #122740

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 6, 2024

Closes #120104
(cherry picked from commit 4b66b6b)

Co-authored-by: Serhiy Storchaka [email protected]

@Yhg1s
Copy link
Member

Yhg1s commented Sep 24, 2024

@terryjreedy Is this PR important enough to sneak in between rc2 and the final 3.13.0, or can it wait until 3.13.1? (The impact is unclear to me.)

@terryjreedy
Copy link
Member

It is safe and has almost no visible effect. Fine to leave it. Ditto for #124325 typos. #124318 fixes bad behavior when newbies ask "What happens in IDLE if I enter while 1: 1. (I wonder if I could automate a test?) Nice but can wait as it is a toy experiment doing the opposite of what the IDLE doc recommends. The fix reverts a now unneeded change but theoretically correct change that fixed a mac-only test failure, but with this side effect. Move on if you want. Any important upcoming changes would be too invasive to merge before .0 even if ready.

@terryjreedy
Copy link
Member

@Yhg1s Since you are doing an rc3, I would prefer this and the other 2 prs linked above be included, but especially the second. As implied, it reverts the code to what always worked before except in an automated test on macOS.

@Yhg1s
Copy link
Member

Yhg1s commented Sep 27, 2024

I don't plan to do an rc3. (We don't really have time.)

@Yhg1s Yhg1s merged commit 4a58bdb into python:3.13 Sep 27, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDLE uses incorrect screen dimension units
4 participants