gh-117657: Fix TSAN races in setobject.c #121511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `used` field must be written using atomic stores because `set_len` and iterators may access the field concurrently without holding the per-object lock.
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 9, 2024
The `used` field must be written using atomic stores because `set_len` and iterators may access the field concurrently without holding the per-object lock. (cherry picked from commit 9c08f40) Co-authored-by: Sam Gross <[email protected]>
|
GH-121541 is a backport of this pull request to the 3.13 branch. |
colesbury
added a commit
that referenced
this pull request
Jul 9, 2024
The `used` field must be written using atomic stores because `set_len` and iterators may access the field concurrently without holding the per-object lock. (cherry picked from commit 9c08f40) Co-authored-by: Sam Gross <[email protected]>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
The `used` field must be written using atomic stores because `set_len` and iterators may access the field concurrently without holding the per-object lock.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
The `used` field must be written using atomic stores because `set_len` and iterators may access the field concurrently without holding the per-object lock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
usedfield must be written using atomic stores becauseset_lenand iterators may access the field concurrently without holding the per-object lock.