gh-121460: Skip freeing unallocated arenas #121491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanor
force-pushed
the
skip-unallocated-free
branch
from
2be7dc6 to
5984c54
Compare
|
All commit authors signed the Contributor License Agreement. |
`munmap(NULL)` is not noop, like `free(NULL)` is. Fixes an observed testsuite hang on 32-bit ARM systems.
stefanor
force-pushed
the
skip-unallocated-free
branch
from
1335c3f to
7293e79
Compare
|
Should this be backported to 3.12? I'm guessing yes. |
|
Thanks @stefanor for the PR, and @ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 10, 2024
`munmap(NULL)` is not noop, like `free(NULL)` is. Fixes an observed testsuite hang on 32-bit ARM systems. (cherry picked from commit a802277) Co-authored-by: Stefano Rivera <[email protected]>
|
GH-121589 is a backport of this pull request to the 3.13 branch. |
ericsnowcurrently
pushed a commit
that referenced
this pull request
Jul 10, 2024
`munmap(NULL)` is not noop, like `free(NULL)` is. Fixes an observed testsuite hang on 32-bit ARM systems. (cherry picked from commit a802277, AKA gh-121491) Co-authored-by: Stefano Rivera <[email protected]>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
`munmap(NULL)` is not noop, like `free(NULL)` is. Fixes an observed testsuite hang on 32-bit ARM systems.
The code this touched is present in 3.12, but it's not being called blindly on arenas that may not be in use. So, I don't think 3.12 needs this patch. |
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
`munmap(NULL)` is not noop, like `free(NULL)` is. Fixes an observed testsuite hang on 32-bit ARM systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
munmap(NULL)is not noop, likefree(NULL)is.Fixes an observed testsuite hang on 32-bit ARM systems.