Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121035: Improve logging flow diagram for dark/light modes. #121254

Merged
merged 1 commit into from
Jul 2, 2024
Merged

gh-121035: Improve logging flow diagram for dark/light modes. #121254

merged 1 commit into from
Jul 2, 2024

Conversation

vsajip
Copy link
Member

@vsajip vsajip commented Jul 2, 2024 •
edited by github-actions bot
Loading

@vsajip vsajip added docs Documentation in the Doc dir skip news labels Jul 2, 2024
@vsajip vsajip self-assigned this Jul 2, 2024
@bedevere-app bedevere-app bot mentioned this pull request Jul 2, 2024
Closed
@vsajip vsajip merged commit bfe0e4d into python:main Jul 2, 2024
29 checks passed
@vsajip vsajip deleted the logging-flow-diagram branch July 2, 2024 08:13
@vsajip vsajip added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jul 2, 2024
@miss-islington-app
Copy link

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@vsajip vsajip added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jul 2, 2024
@miss-islington-app
Copy link

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@vsajip vsajip mentioned this pull request Jul 2, 2024
Merged
@bessman
Copy link
Contributor

bessman commented Jul 2, 2024

This does not work for me with the combination of browser dark mode + light theme selected via drop down. The diagram rendered as white on white in this case.

It does work for browser light mode + dark theme selected via drop down, however.

@vsajip
Copy link
Member Author

vsajip commented Jul 2, 2024

OK, thanks for the feedback. I'll look at that case.

@vsajip
Copy link
Member Author

vsajip commented Jul 2, 2024

I have a new PR, #121265 - it should fix the problem. Please feel free to try it out.

I created some screenshots: In the following, names are X-Y where the X is the browser (Firefox) mode and Y is the theme selector value.

auto-auto:
auto-auto

auto-light:
auto-light

auto-dark:
auto-dark

light-auto:
light-auto

light-light:
light-light

light-dark:
light-dark

dark-auto:
dark-auto

dark-light:
dark-light

dark-dark:
dark-dark

Akasurde pushed a commit to Akasurde/cpython that referenced this pull request Jul 3, 2024
@vsajip @Akasurde
pythongh-121035: Improve logging flow diagram for dark/light modes. (p…
0972089 
…ythonGH-121254)
vsajip added a commit to vsajip/cpython that referenced this pull request Jul 3, 2024
@vsajip
[3.12] pythongh-121035: Improve logging flow diagram for dark/light m…
bd43fcf 
…odes. (pythonGH-121254)

(cherry picked from commit bfe0e4d)

Co-authored-by: Vinay Sajip <[email protected]>
@vsajip vsajip mentioned this pull request Jul 3, 2024
Merged
@bedevere-app
Copy link

bedevere-app bot commented Jul 3, 2024

GH-121316 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jul 3, 2024
vsajip added a commit to vsajip/cpython that referenced this pull request Jul 3, 2024
@vsajip
[3.13] pythongh-121035: Improve logging flow diagram for dark/light m…
845d861 
…odes. (pythonGH-121254)

(cherry picked from commit bfe0e4d)

Co-authored-by: Vinay Sajip <[email protected]>
@vsajip vsajip mentioned this pull request Jul 3, 2024
Merged
@bedevere-app
Copy link

bedevere-app bot commented Jul 3, 2024

GH-121317 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 3, 2024
vsajip added a commit that referenced this pull request Jul 3, 2024
@vsajip
[3.12] gh-121035: Improve logging flow diagram for dark/light modes. (G…
c3f393c 
…H-121254) (GH-121316)

(cherry picked from commit bfe0e4d)
vsajip added a commit that referenced this pull request Jul 3, 2024
@vsajip
[3.13] gh-121035: Improve logging flow diagram for dark/light modes. (G…
b62605d 
…H-121254) (GH-121317)

(cherry picked from commit bfe0e4d)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@vsajip @noahbkim
pythongh-121035: Improve logging flow diagram for dark/light modes. (p…
7365546 
…ythonGH-121254)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vsajip @estyxx
pythongh-121035: Improve logging flow diagram for dark/light modes. (p…
aa70c04 
…ythonGH-121254)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vsajip vsajip

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vsajip @bessman