Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119447: Fix build with _PY_SHORT_FLOAT_REPR == 0 #121178

Merged
merged 1 commit into from
Jun 30, 2024
Merged

gh-119447: Fix build with _PY_SHORT_FLOAT_REPR == 0 #121178

merged 1 commit into from
Jun 30, 2024

Conversation

yu-re-ka
Copy link

@yu-re-ka yu-re-ka commented Jun 30, 2024 •
edited by bedevere-app bot
Loading

After 3c57971 the dtoa_runtime_state is referenced from pycore_runtime.h (later moved to Include/internal/pycore_interp.h) unconditionally, but the dtoa_runtime_state struct is not defined in all cases. Use the "not_used" definition of dtoa_runtime_state which already exists for the Py_USING_MEMORY_DEBUGGER case on those platforms as well.

@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Jun 30, 2024 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jun 30, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app bot mentioned this pull request Jun 30, 2024
Closed
vstinner
vstinner approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner added skip news needs backport to 3.13 bugs and security fixes labels Jun 30, 2024
@vstinner vstinner merged commit c3677be into python:main Jun 30, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @yu-re-ka for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 30, 2024
@yuyuyureka @miss-islington
pythongh-119447: Fix build with _PY_SHORT_FLOAT_REPR == 0 (pythonGH-1…
31d7f15 
…21178)

(cherry picked from commit c3677be)

Co-authored-by: Yureka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 30, 2024

GH-121179 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 30, 2024
@vstinner vstinner added the needs backport to 3.12 bug and security fixes label Jun 30, 2024
@miss-islington-app
Copy link

Thanks @yu-re-ka for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @yu-re-ka and @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c3677befbecbd7fa94cde8c1fecaa4cc18e6aa2b 3.12

@yu-re-ka
Copy link
Author

Also needs back port to 3.12. The diff for that is available here: https://github.com/yu-re-ka/nixpkgs/blob/27fa2eb77ee683db4e9318d58c5fe102b25cfb6e/pkgs/development/interpreters/python/cpython/3.12/0001-Fix-build-with-_PY_SHORT_FLOAT_REPR-0.patch

@bedevere-app
Copy link

bedevere-app bot commented Jun 30, 2024

GH-121180 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jun 30, 2024
@yu-re-ka yu-re-ka deleted the fix-dtoa branch June 30, 2024 09:47
vstinner pushed a commit to vstinner/cpython that referenced this pull request Jun 30, 2024
@yuyuyureka @vstinner
pythongh-119447: Fix build with _PY_SHORT_FLOAT_REPR == 0 (python#121178
42c4e94 
)

(cherry picked from commit c3677be)
@vstinner
Copy link
Member

Also needs back port to 3.12. The diff for that is available here: https://github.com/yu-re-ka/nixpkgs/blob/27fa2eb77ee683db4e9318d58c5fe102b25cfb6e/pkgs/development/interpreters/python/cpython/3.12/0001-Fix-build-with-_PY_SHORT_FLOAT_REPR-0.patch

Right. I created a PR manually for 3.12 using a cherry-pick of your fix: #121180.

vstinner added a commit that referenced this pull request Jun 30, 2024
@vstinner @yuyuyureka
[3.12] gh-119447: Fix build with _PY_SHORT_FLOAT_REPR == 0 (#121178) (#…
e0b9905 
…121180)

gh-119447: Fix build with _PY_SHORT_FLOAT_REPR == 0 (#121178)

(cherry picked from commit c3677be)

Co-authored-by: Yureka <[email protected]>
vstinner pushed a commit that referenced this pull request Jun 30, 2024
@miss-islington @yuyuyureka
[3.13] gh-119447: Fix build with _PY_SHORT_FLOAT_REPR == 0 (GH-121178) (
7776179 
#121179)

gh-119447: Fix build with _PY_SHORT_FLOAT_REPR == 0 (GH-121178)
(cherry picked from commit c3677be)

Co-authored-by: Yureka <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@yuyuyureka @mrahtz
pythongh-119447: Fix build with _PY_SHORT_FLOAT_REPR == 0 (python#121178
b215211 
)
@yu-re-ka yu-re-ka mentioned this pull request Jul 7, 2024
Closed
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@yuyuyureka @noahbkim
pythongh-119447: Fix build with _PY_SHORT_FLOAT_REPR == 0 (python#121178
b55cd61 
)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@yuyuyureka @estyxx
pythongh-119447: Fix build with _PY_SHORT_FLOAT_REPR == 0 (python#121178
24ca7a3 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

@vstinner vstinner

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yu-re-ka @vstinner @yuyuyureka