docs: puremagic.what() as replacement for imghdr.what() #120871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
docs
cdgriffith
approved these changes
Jun 24, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 24, 2024
) (cherry picked from commit 22b8a35) Co-authored-by: Christian Clauss <[email protected]>
|
GH-120951 is a backport of this pull request to the 3.13 branch. |
vstinner
pushed a commit
that referenced
this pull request
Jun 24, 2024
…0871) (#120951) docs: puremagic.what() as replacement for imghdr.what() (GH-120871) (cherry picked from commit 22b8a35) Co-authored-by: Christian Clauss <[email protected]>
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puremagic.what()was created as a drop-in replacement forimghdr.what()* :mod:`!imghdr`: use the projects :pypi:`filetype`, :pypi:`puremagic`, or :pypi:`python-magic` instead. + The `puremagic.what()` function can be used to replace + the `imghdr.what()` function for all file formats that + were supported by `imghdr`. (Contributed by Victor Stinner in :gh:`104773`.)puremagicwas chosen for file format compatibility and ease of installation.imghdr.what()cdgriffith/puremagic#72imghdr.what()cdgriffith/puremagic#76imghdr_strictoption to.what()to deliver the same false positives cdgriffith/puremagic#81Implementation and tests:
Other attempts for
filetype.pyandpython-magicthat were not merged:imghdr.what()h2non/filetype.py#178imghdr.what()ahupp/python-magic#326@Yhg1s @vstinner @cdgriffith Your reviews, please.
📚 Documentation preview 📚: https://cpython-previews--120871.org.readthedocs.build/