annotations: expand documentation on "simple" assignment targets #120535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This behavior is rather surprising and it was not clearly specified.
JelleZijlstra
added
docs
AlexWaygood
reviewed
Jun 15, 2024
There was a problem hiding this comment.
Thanks, I agree that this can be usefully clarified.
Separately to improving the documentation, we could consider changing the implementation to use a bool for the simple field. I also wonder why annotations for complex targets are evaluated at all if these annotations are never stored in the __annotations__ dictionary -- but this problem will shortly be going away with PEP-649, so I suppose we don't really need to worry about it too much :-)
Co-authored-by: Alex Waygood <[email protected]>
I think that's hard because bool isn't a builtin type in ASDL. |
AlexWaygood
approved these changes
Jun 15, 2024
|
Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2024
…honGH-120535) This behavior is rather surprising and it was not clearly specified. (cherry picked from commit 9e0b11e) Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
|
GH-120555 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 15, 2024
…honGH-120535) This behavior is rather surprising and it was not clearly specified. (cherry picked from commit 9e0b11e) Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
|
GH-120556 is a backport of this pull request to the 3.12 branch. |
JelleZijlstra
added a commit
that referenced
this pull request
Jun 15, 2024
…ts (GH-120535) (#120556) This behavior is rather surprising and it was not clearly specified. (cherry picked from commit 9e0b11e) Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
JelleZijlstra
added a commit
that referenced
this pull request
Jun 15, 2024
…ts (GH-120535) (#120555) This behavior is rather surprising and it was not clearly specified. (cherry picked from commit 9e0b11e) Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
…hon#120535) This behavior is rather surprising and it was not clearly specified. Co-authored-by: Alex Waygood <[email protected]>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…hon#120535) This behavior is rather surprising and it was not clearly specified. Co-authored-by: Alex Waygood <[email protected]>
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…hon#120535) This behavior is rather surprising and it was not clearly specified. Co-authored-by: Alex Waygood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior is rather surprising and it was not clearly specified.
📚 Documentation preview 📚: https://cpython-previews--120535.org.readthedocs.build/