Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117657: Fix TSan reported data race on ioctl_works #120175

Merged
merged 2 commits into from
Jun 17, 2024
Merged

gh-117657: Fix TSan reported data race on ioctl_works #120175

merged 2 commits into from
Jun 17, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Jun 6, 2024 •
edited by bedevere-app bot
Loading

@colesbury colesbury requested a review from DinoV June 6, 2024 19:23
@bedevere-app bedevere-app bot mentioned this pull request Jun 6, 2024
Open
vstinner
vstinner approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I tested functionally that setting ioctl_works to 0 falls back on fcntl() as expected by forcing ioctl_works to 0 and by checking syscalls with strace.

@aisk aisk mentioned this pull request Jun 13, 2024
Closed
@colesbury colesbury merged commit 460cc9e into python:main Jun 17, 2024
34 checks passed
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@colesbury colesbury deleted the gh-117657-set-inheritable branch June 17, 2024 17:23
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 17, 2024
@colesbury @miss-islington
pythongh-117657: Fix TSan reported data race on ioctl_works (pythonGH…
df6bce4 
…-120175)

(cherry picked from commit 460cc9e)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 17, 2024

GH-120654 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 17, 2024
colesbury added a commit that referenced this pull request Jun 17, 2024
@miss-islington @colesbury
[3.13] gh-117657: Fix TSan reported data race on ioctl_works (GH-120175…
0dbb86c 
…) (#120654)

(cherry picked from commit 460cc9e)

Co-authored-by: Sam Gross <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@colesbury @mrahtz
pythongh-117657: Fix TSan reported data race on ioctl_works (python#1…
cffedc1 
…20175)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@colesbury @noahbkim
pythongh-117657: Fix TSan reported data race on ioctl_works (python#1…
2958817 
…20175)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@colesbury @estyxx
pythongh-117657: Fix TSan reported data race on ioctl_works (python#1…
2c8eddd 
…20175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aisk aisk aisk left review comments

@corona10 corona10 corona10 approved these changes

@vstinner vstinner vstinner approved these changes

@DinoV DinoV Awaiting requested review from DinoV

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colesbury @vstinner @aisk @corona10