Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-120026: deprecate (soft) Py_HUGE_VAL macro #120027

Merged
merged 8 commits into from
Nov 1, 2024

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented Jun 4, 2024

@skirpichev
Copy link
Member Author

As mentioned here I'm not sure that Py_NAN/INFINITY now are really required.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few wording suggestions.

A

Doc/whatsnew/3.14.rst Outdated Show resolved Hide resolved
Include/pymath.h Outdated Show resolved Hide resolved
@skirpichev
Copy link
Member Author

CC @vstinner

* :func:`!asyncio.iscoroutinefunction` is deprecated
and will be removed in Python 3.16,
use :func:`inspect.iscoroutinefunction` instead.
(Contributed by Jiahao Li and Kumar Aditya in :gh:`122875`.)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks unrelated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, artefact of some conflict resolution. Fixed, thanks.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner enabled auto-merge (squash) November 1, 2024 16:27
@vstinner vstinner merged commit 8477951 into python:main Nov 1, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants