Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119786: move exception handling doc to InternalDocs #119815

Merged
merged 10 commits into from
Jun 3, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented May 30, 2024

I edited it a bit too (see individual commits).

Basically I removed the comparison with pre-3.11 exception handling. And converted to markdown.

@iritkatriel iritkatriel force-pushed the implementation_doc branch from ae497e6 to 7719234 Compare May 30, 2024 23:47
@iritkatriel iritkatriel requested a review from markshannon May 30, 2024 23:52
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise looks good.

InternalDocs/exception_handling.md Outdated Show resolved Hide resolved
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo needs fixing before merging.

InternalDocs/exception_handling.md Outdated Show resolved Hide resolved
Co-authored-by: Mark Shannon <[email protected]>
@iritkatriel iritkatriel enabled auto-merge (squash) June 3, 2024 09:11
@iritkatriel iritkatriel merged commit 367adc9 into python:main Jun 3, 2024
31 checks passed
mliezun pushed a commit to mliezun/cpython that referenced this pull request Jun 3, 2024
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants