-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subprocess docs: Fix semantically important typo #119752
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonGH-25416 accidentally replaced a reference to the *stderr* argument of `subprocess.run` with a reference to the *stdin* argument. *stdin* is not affected by the `check_output` option.
zware
added
docs
Documentation in the Doc dir
skip issue
skip news
needs backport to 3.11
only security fixes
needs backport to 3.12
bug and security fixes
needs backport to 3.13
bugs and security fixes
labels
May 29, 2024
erlend-aasland
approved these changes
May 29, 2024
Ouch, thanks a lot for fixing that! |
Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 29, 2024
pythonGH-25416 accidentally replaced a reference to the *stderr* argument of `subprocess.run` with a reference to the *stdin* argument. *stdin* is not affected by the `check_output` option. (cherry picked from commit 2cc3502) Co-authored-by: Zachary Ware <[email protected]>
GH-119757 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 29, 2024
pythonGH-25416 accidentally replaced a reference to the *stderr* argument of `subprocess.run` with a reference to the *stdin* argument. *stdin* is not affected by the `check_output` option. (cherry picked from commit 2cc3502) Co-authored-by: Zachary Ware <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 29, 2024
pythonGH-25416 accidentally replaced a reference to the *stderr* argument of `subprocess.run` with a reference to the *stdin* argument. *stdin* is not affected by the `check_output` option. (cherry picked from commit 2cc3502) Co-authored-by: Zachary Ware <[email protected]>
GH-119758 is a backport of this pull request to the 3.12 branch. |
GH-119759 is a backport of this pull request to the 3.11 branch. |
AlexWaygood
pushed a commit
that referenced
this pull request
May 30, 2024
…119757) subprocess docs: Fix semantically important typo (GH-119752) GH-25416 accidentally replaced a reference to the *stderr* argument of `subprocess.run` with a reference to the *stdin* argument. *stdin* is not affected by the `check_output` option. (cherry picked from commit 2cc3502) Co-authored-by: Zachary Ware <[email protected]>
AlexWaygood
pushed a commit
that referenced
this pull request
May 30, 2024
…119758) subprocess docs: Fix semantically important typo (GH-119752) GH-25416 accidentally replaced a reference to the *stderr* argument of `subprocess.run` with a reference to the *stdin* argument. *stdin* is not affected by the `check_output` option. (cherry picked from commit 2cc3502) Co-authored-by: Zachary Ware <[email protected]>
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
pythonGH-25416 accidentally replaced a reference to the *stderr* argument of `subprocess.run` with a reference to the *stdin* argument. *stdin* is not affected by the `check_output` option.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
pythonGH-25416 accidentally replaced a reference to the *stderr* argument of `subprocess.run` with a reference to the *stdin* argument. *stdin* is not affected by the `check_output` option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH-25416 accidentally replaced a reference to the stderr argument of
subprocess.run
with a reference to the stdin argument. stdin isnot affected by the
check_output
option.📚 Documentation preview 📚: https://cpython-previews--119752.org.readthedocs.build/