Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-111201: Speed up paste mode in the REPL #119341

Merged
merged 4 commits into from
May 22, 2024
Merged

gh-111201: Speed up paste mode in the REPL #119341

merged 4 commits into from
May 22, 2024

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented May 21, 2024 •
edited by bedevere-app bot
Loading

@pablogsal pablogsal requested a review from lysnikolaou May 21, 2024 18:53
@bedevere-app bedevere-app bot mentioned this pull request May 21, 2024
Closed
7 tasks
@pablogsal
Copy link
Member Author

This depends on #119318 landing first

@pablogsal pablogsal added the topic-repl Related to the interactive shell label May 21, 2024
@ambv ambv added the skip news label May 21, 2024
@ambv ambv merged commit e6572e8 into python:main May 22, 2024
39 checks passed
@lysnikolaou
Copy link
Member

lysnikolaou commented May 22, 2024 •
edited
Loading

I think that this has broken paste. Pasting code shows the last character of the pasted line only. The whole buffer is shown after hitting backspace. If arrows are used between the paste and the backspace, the buffer gets completely messed up.

cc @ambv @pablogsal

@pablogsal
Copy link
Member Author

Hummm, we live tested this several times. I wonder if there is some weird interaction with other PRs we landed

@pablogsal
Copy link
Member Author

We should revert meanwhile I think

@pablogsal
Copy link
Member Author

@lysnikolaou @ambv WDYT?

@lysnikolaou
Copy link
Member

+1 for reverting, otherwise it might be hard to do manual testing of PRs at the sprints.

@lysnikolaou
Copy link
Member

lysnikolaou commented May 22, 2024 •
edited
Loading

#119432 fixes this.

lysnikolaou pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2024
@pablogsal @ambv @lysnikolaou
pythongh-111201: Speed up paste mode in the REPL (python#119341)
1909b7b 
Co-authored-by: Łukasz Langa <[email protected]>
lysnikolaou added a commit that referenced this pull request May 23, 2024
@miss-islington @pablogsal
@ambv @lysnikolaou
[3.13] gh-111201: Speed up paste mode in the REPL (#119341) (GH-119432)…
58dbb4a 
… (#119439)

(cherry picked from commit e6572e8)

Also includes:

* gh-111201: Use calc_complete_screen after bracketed paste in PyREPL (GH-119432)
(cherry picked from commit 14b063c)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Lysandros Nikolaou <[email protected]>
@pablogsal pablogsal deleted the speed branch May 23, 2024 12:18
@treyhunner treyhunner mentioned this pull request May 24, 2024
Closed
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@pablogsal @ambv @estyxx
pythongh-111201: Speed up paste mode in the REPL (python#119341)
3079f8d 
Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees
No one assigned
Labels
skip news topic-repl Related to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogsal @lysnikolaou @ambv