-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-119121: Fix and test async.staggered.staggered_race
#119173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…nGH-119173) (cherry picked from commit 16b46eb) Co-authored-by: Nikita Sobolev <[email protected]>
GH-119206 is a backport of this pull request to the 3.13 branch. |
|
…pythonGH-119173) (python#119206) pythongh-119121: Fix and test `async.staggered.staggered_race` (pythonGH-119173) (cherry picked from commit 16b46eb) Co-authored-by: Nikita Sobolev <[email protected]>
I've added a couple of tests for this function as well, to prevent simple future regressions.
Please, note that this set of tests is clearly not enough to cover all the cases in this function. Right now it only covers several simple use-cases. In the future we can also test:
loop=
argument__debug__
routedelay
corner casesBut, I think that testing green path is good enough for now.
I can commit more tests in the next PRs, since they will require quite a lot of effort.
Refs #114282
This PR does need a 3.13 backport.
asyncio.staggered
is missingtyping
import #119121