gh-119146: Update paths in jit.yml
#119147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFY00
approved these changes
May 18, 2024
There was a problem hiding this comment.
We should actually be able to ignore Python/perf_jit_trampoline.c by using a negative matching pattern: !Python/perf_jit_trampoline.c.
Other than that, looks good to me.
|
Oh! I totally didn't know about that. I'll take a look at adding that when I also add .h files to the paths (since I missed adding those in too). |
AlexWaygood
reviewed
May 18, 2024
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
|
Yeah, that's a fair callout! |
Co-authored-by: Brandt Bucher <[email protected]>
|
Thanks for the PR! Shall we backport it, or close the issue? |
|
I think it's ok to backport it to 3.13. |
|
Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2024
(cherry picked from commit 5307f44) Co-authored-by: Savannah Ostrowski <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
|
GH-119226 is a backport of this pull request to the 3.13 branch. |
This was referenced Jun 12, 2024
Merged
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Co-authored-by: Alex Waygood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pathsinjit.yml#119146