Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix typos in documentation #118815

Merged
merged 1 commit into from
May 10, 2024
Merged

Docs: fix typos in documentation #118815

merged 1 commit into from
May 10, 2024

Conversation

xyb
Copy link
Contributor

@xyb xyb commented May 9, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels May 9, 2024
vsajip
vsajip requested changes May 9, 2024
View reviewed changes
Copy link
Member

@vsajip vsajip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other changes look fine to me.

Doc/library/bz2.rst Outdated Show resolved Hide resolved
Doc/library/bz2.rst Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented May 9, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Privat33r-dev
Privat33r-dev suggested changes May 9, 2024
View reviewed changes
Copy link
Contributor

@Privat33r-dev Privat33r-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, revert the latin changes as suggested. Other changes are good, thank you for your contribution.

Doc/library/bz2.rst Outdated Show resolved Hide resolved
Doc/library/bz2.rst Outdated Show resolved Hide resolved
@xyb
Copy link
Contributor Author

xyb commented May 10, 2024

@vsajip @Privat33r-dev Thank you for your advices. I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented May 10, 2024

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from vsajip May 10, 2024 03:34
@vsajip vsajip merged commit 17a2cc1 into python:main May 10, 2024
26 of 29 checks passed
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
@xyb @SonicField
Docs: fix typos in documentation (pythonGH-118815)
6502eb3
@xyb xyb deleted the fixtypos branch May 10, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Privat33r-dev Privat33r-dev Privat33r-dev approved these changes

@vsajip vsajip vsajip approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xyb @vsajip @Privat33r-dev @Eclips4