Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-118767: Improve tests and docs for bool(NotImplemented) #118813

Merged
merged 3 commits into from
May 9, 2024
Merged

gh-118767: Improve tests and docs for bool(NotImplemented) #118813

merged 3 commits into from
May 9, 2024

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 9, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels May 9, 2024
@JelleZijlstra JelleZijlstra changed the title gh-118775: Improve tests and docs for bool(NotImplemented) gh-118767: Improve tests and docs for bool(NotImplemented) May 9, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 9, 2024
Closed
serhiy-storchaka
serhiy-storchaka approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It is much better now.

I think that the NEWS entry contains a redundant link.

@JelleZijlstra JelleZijlstra enabled auto-merge (squash) May 9, 2024 13:22
@JelleZijlstra JelleZijlstra merged commit 35b5eaa into python:main May 9, 2024
33 checks passed
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 9, 2024
@JelleZijlstra @SonicField
pythongh-118767: Improve tests and docs for bool(NotImplemented) (pyt…
a657dd5 
…hon#118813)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelleZijlstra @serhiy-storchaka