-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove several unused imports in _pyrepl
#118668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Also, if we can do a little bit of refactoring (Not in this PR), can we replace if False: ...
with a if TYPE_CHECKING: ...
? This if False: ...
entries looks weird for me.
|
Oh, I forgot about that. Then let's leave it as it is. |
There is a way to do MYPY = False
if MYPY: # False at runtime, but mypy thinks that it is True
... # do expensive stuff It should be configured using these options: > mypy -h
...
--always-true NAME Additional variable to be considered True (may be
repeated)
--always-false NAME Additional variable to be considered False (may be
repeated)
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.