Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115119: Update Windows installer to mpdecimal 4.0.0 #118506

Merged
merged 5 commits into from
May 3, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 2, 2024

@bedevere-app bedevere-app bot mentioned this pull request May 2, 2024
15 tasks
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 2, 2024

@sethmlarson, I tried to use generate_sbom.py:

$ python3 Tools/build/generate_sbom.py
Version '4.0.0' for package 'mpdecimal not in all 'externalRefs[].referenceLocator' fields

Do I have to manually edit Misc/sbom.spdx.json?

@Eclips4
Copy link
Member

Eclips4 commented May 2, 2024

@SethMichaelLarson, I tried to use generate_sbom.py:

$ python3 Tools/build/generate_sbom.py
Version '4.0.0' for package 'mpdecimal not in all 'externalRefs[].referenceLocator' fields

Do I have to manually edit Misc/sbom.spdx.json?

I think you mean @sethmlarson :)

@sethmlarson
Copy link
Contributor

Thanks for reporting this @erlend-aasland and apologies for the trouble. It wasn't the intent to require the user to update the CPE value, I've opened a PR to automatically update the CPE version value.

If you need to get this update in ASAP, I recommend updating the CPE value manually in Misc/externals.spdx.json.

@erlend-aasland
Copy link
Contributor Author

Thanks for reporting this @erlend-aasland and apologies for the trouble. It wasn't the intent to require the user to update the CPE value, I've opened a PR to automatically update the CPE version value.

Thank you so much!

If you need to get this update in ASAP, I recommend updating the CPE value manually in Misc/externals.spdx.json.

I tried to manually update the value in 3031684.

@erlend-aasland erlend-aasland marked this pull request as ready for review May 3, 2024 07:29
@erlend-aasland erlend-aasland requested review from sethmlarson and a team as code owners May 3, 2024 07:29
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erlend-aasland erlend-aasland merged commit 1324502 into python:main May 3, 2024
36 checks passed
@erlend-aasland erlend-aasland deleted the libmpdec-4.0.0-win branch May 3, 2024 16:00
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants