Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proper permissions for jit.yml workflow #118084

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Set proper permissions for jit.yml workflow #118084

merged 1 commit into from
Apr 22, 2024

Conversation

sobolevn
Copy link
Member

All other CI jobs have this set:

cpython/.github/workflows/lint.yml

Lines 5 to 6 in fefd5d9

permissions:
contents: read

cpython/.github/workflows/mypy.yml

Lines 21 to 22 in fefd5d9

permissions:
contents: read

cpython/.github/workflows/build.yml

Lines 25 to 26 in fefd5d9

permissions:
contents: read

@sobolevn
Copy link
Member Author

Failure look related: https://github.com/python/cpython/actions/runs/8749774588/job/24012037136

brandtbucher
brandtbucher approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, those failures are happening on other PRs too. Looks good, thanks!

@sobolevn sobolevn merged commit fc21c7f into python:main Apr 22, 2024
50 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees
No one assigned
Labels
skip issue skip news topic-JIT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sobolevn @brandtbucher