New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-112075: Lock when inserting into shared keys #117824

Closed

colesbury wants to merge 2 commits into python:main from colesbury:gh-112075-lock-split-keys

Contributor

colesbury commented Apr 12, 2024 •

edited by bedevere-app bot

Loading

This is a draft PR similar to #117528, but:

Separates out the handling of split keys
Doesn't yet handle the necessary locking in _Py_dict_lookup for things like the PyDict_GetItemRef locking fallback.

Issue: Make dict objects thread-safe in --disable-gil builds #112075


          pythongh-112075: Lock when inserting into shared keys

3d270d2

bedevere-app bot mentioned this pull request

Make dict objects thread-safe in --disable-gil builds #112075

Closed

colesbury added the skip news label

colesbury mentioned this pull request

Make the Python test suite pass with the GIL disabled #116749

Closed


          Fix return type

2e5797e

colesbury closed this

Contributor Author

colesbury commented Apr 26, 2024

Addressed in #117528

colesbury deleted the gh-112075-lock-split-keys branch

July 16, 2024 19:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

methane Awaiting requested review from methane methane will be requested when the pull request is marked ready for review methane is a code owner

markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

Labels