GH-115060: Speed up pathlib.Path.glob()
by not scanning literal parts
#117732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't bother calling
os.scandir()
to scan for literal pattern segments, likefoo
infoo/*.py
. Instead, append the segment(s) as-is and call through to the next selector withexists=False
, which signals that the path might not exist. Subsequent selectors will callos.scandir()
oros.lstat()
to filter out missing paths as needed.Timings:
pathlib.Path.glob()
by removing redundant regex matching #115060