gh-117655: Fix `test_strptime` raises a DeprecationWarning #117668

nineteendo · 2024-04-09T07:58:53Z

Issue: test_strptime raises a DeprecationWarning #117655

This reverts commit 1f794a7.

erlend-aasland · 2024-04-18T12:39:32Z

@erlend-aasland, does this look better?

I'm not the correct person to review this. I'll request Greg's review, since he authored the recent change that introduced this deprecation warning.

erlend-aasland · 2024-04-18T12:42:16Z

Please give Greg (and Paul) reasonable time to review before eventually pinging them. Quoting the devguide:

Getting your pull request reviewed requires a reviewer to have the spare time and motivation to look at your pull request (we cannot force anyone to review pull requests and no one is employed to look at pull requests). If your pull request has not received any notice from reviewers (i.e., no comment made) after one month, first “ping” the issue on the issue tracker to remind the subscribers that the pull request needs a review. If you don’t get a response within a week after pinging the issue, you can post on the Core Development Discourse category to ask for someone to review your pull request.

nineteendo · 2024-04-18T12:48:01Z

OK.

Lib/test/datetimetester.py

nineteendo · 2024-05-11T18:38:11Z

Thanks. I'll ask on Discourse for someone else to review this as well.

nineteendo · 2024-05-11T21:45:57Z

Thanks, I didn't dare pinging you after the comment of Erlend.

gpshead · 2024-05-11T21:48:18Z

no problem, i'm always overflowing with notifications so I easily miss things or have other priorities at times. thanks for the cleanup! I probably should've done this type of thing when making the original change. thanks for the pings!

miss-islington-app · 2024-05-11T21:51:17Z

Thanks @nineteendo for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

…rning (pythonGH-117668) * Fix `test_strptime` raises a DeprecationWarning * Ignore deprecation warnings where appropriate. * Update Lib/test/datetimetester.py This is follow on work to silence unnecessary warnings from the test suite that changes for python#70647 added. (cherry picked from commit abead54) Co-authored-by: Nice Zombies <[email protected]>

bedevere-app · 2024-05-11T21:51:31Z

GH-118956 is a backport of this pull request to the 3.13 branch.

…arning (GH-117668) (GH-118956) gh-117655: Prevent `test_strptime` from raising a DeprecationWarning (GH-117668) * Fix `test_strptime` raises a DeprecationWarning * Ignore deprecation warnings where appropriate. * Update Lib/test/datetimetester.py This is follow on work to silence unnecessary warnings from the test suite that changes for #70647 added. (cherry picked from commit abead54) Co-authored-by: Nice Zombies <[email protected]>

bedevere-bot · 2024-05-12T00:20:36Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu NoGIL 3.13 has failed when building commit d309474.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1422/builds/11) and take a look at the build logs.
Check if the failure is related to this commit (d309474) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1422/builds/11

Failed tests:

worker>
<regrtest
test_math

Failed subtests:

test_map_timeout - test.test_concurrent_futures.test_process_pool.ProcessPoolSpawnProcessPoolExecutorTest.test_map_timeout

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/single.py", line 178, in _runtest_env_changed_exc
    _load_run_test(result, runtests)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/single.py", line 125, in _load_run_test
    test_mod = importlib.import_module(module_name)
  File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/importlib/__init__.py", line 88, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1324, in _find_and_load_unlocked
ModuleNotFoundError: No module named 'test.<regrtest worker>'


Traceback (test.test_zipimport.CompressedZipImportTestCase.testTraceback) ... ok


Traceback (test.test_zipimport.UncompressedZipImportTestCase.testTraceback) ... ok


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 71, in test_map_timeout
    self.assertEqual([None, None], results)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Lists differ: [None, None] != []


Traceback (most recent call last):
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/__init__.py", line 199, in _force_run
Warning --     return func(*args)
Warning -- OSError: [Errno 39] Directory not empty: '/tmp/test_python_7s3a3wxc/tmpx3992ijw/python-installation/lib/python3.13'
Warning -- 
Warning -- During handling of the above exception, another exception occurred:
Warning -- 
Warning -- Traceback (most recent call last):
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/run_workers.py", line 393, in run
Warning --     mp_result = self._runtest(test_name)
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/run_workers.py", line 353, in _runtest
Warning --     retcode, tmp_files = self.run_tmp_files(worker_runtests,
Warning --                          ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
Warning --                                             stdout_file.fileno())
Warning --                                             ^^^^^^^^^^^^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/libregrtest/run_workers.py", line 293, in run_tmp_files
Warning --     os_helper.rmtree(tmp_dir)
Warning --     ~~~~~~~~~~~~~~~~^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 465, in rmtree
Warning --     _rmtree(path)
Warning --     ~~~~~~~^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 449, in _rmtree
Warning --     _rmtree_inner(path)
Warning --     ~~~~~~~~~~~~~^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 445, in _rmtree_inner
Warning --     _rmtree_inner(fullname)
Warning --     ~~~~~~~~~~~~~^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 445, in _rmtree_inner
Warning --     _rmtree_inner(fullname)
Warning --     ~~~~~~~~~~~~~^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 445, in _rmtree_inner
Warning --     _rmtree_inner(fullname)
Warning --     ~~~~~~~~~~~~~^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/os_helper.py", line 446, in _rmtree_inner
Warning --     _force_run(path, os.rmdir, fullname)
Warning --     ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^
Warning --   File "/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/__init__.py", line 210, in _force_run
Warning --     return func(*args)
Warning -- OSError: [Errno 39] Directory not empty: '/tmp/test_python_7s3a3wxc/tmpx3992ijw/python-installation/lib/python3.13'
Kill <WorkerThread #1 running test=test_source_encoding pid=231378 time=4 min 41 sec> process group
Kill <WorkerThread #3 running test=test_pep646_syntax pid=234011 time=1.1 sec> process group
Kill <WorkerThread #4 running test=test_regrtest pid=232605 time=2 min 11 sec> process group
Kill <WorkerThread #5 running test=test_cppext pid=226868 time=9 min 48 sec> process group
Kill <WorkerThread #6 running test=test_hashlib pid=233306 time=1 min 7 sec> process group
Kill <WorkerThread #7 running test=test.test_asyncio.test_queues pid=233907 time=4.1 sec> process group
Kill <WorkerThread #8 running test=test.test_multiprocessing_spawn.test_misc pid=230565 time=4 min 50 sec> process group
Kill <WorkerThread #9 running test=test.test_gdb.test_pretty_print pid=229100 time=8 min 27 sec> process group
Kill <WorkerThread #10 running test=test_pyclbr pid=233591 time=36.5 sec> process group

bedevere-bot · 2024-05-12T01:02:03Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu NoGIL Refleaks 3.x has failed when building commit abead54.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1226/builds/1859) and take a look at the build logs.
Check if the failure is related to this commit (abead54) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1226/builds/1859

Failed tests:

test.test_concurrent_futures.test_process_pool
test.test_multiprocessing_spawn.test_misc
test_eintr
test.test_multiprocessing_spawn.test_manager

Failed subtests:

test_map_timeout - test.test_concurrent_futures.test_process_pool.ProcessPoolForkserverProcessPoolExecutorTest.test_map_timeout
test_map_timeout - test.test_concurrent_futures.test_process_pool.ProcessPoolSpawnProcessPoolExecutorTest.test_map_timeout
test_wait_integer - test.test_multiprocessing_spawn.test_misc.TestWait.test_wait_integer
test_all - test.test_eintr.EINTRTests.test_all
test_lockf - main.FNTLEINTRTest.test_lockf

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 313, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 5329, in child
    join_process(p)
    ~~~~~~~~~~~~^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 105, in join_process
    threading_helper.join_thread(process)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/support/threading_helper.py", line 116, in join_thread
    raise AssertionError(msg)
AssertionError: failed to join the thread in 30.0 seconds
Process Process-314:1:
Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 313, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 5329, in child
    join_process(p)
    ~~~~~~~~~~~~^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 105, in join_process
    threading_helper.join_thread(process)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/support/threading_helper.py", line 116, in join_thread
    raise AssertionError(msg)
AssertionError: failed to join the thread in 30.0 seconds
k


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 313, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1847, in task
    self.f(*self.args)
    ~~~~~~^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1912, in multipass
    barrier.wait()
    ~~~~~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/managers.py", line 1108, in wait
    return self._callmethod('wait', (timeout,))
           ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/managers.py", line 840, in _callmethod
    raise convert_to_error(kind, result)
threading.BrokenBarrierError
Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 313, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1847, in task
    self.f(*self.args)
    ~~~~~~^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1912, in multipass
    barrier.wait()
    ~~~~~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/managers.py", line 1108, in wait
    return self._callmethod('wait', (timeout,))
           ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/managers.py", line 840, in _callmethod
    raise convert_to_error(kind, result)
threading.BrokenBarrierError
Process Process-92:
Process Process-90:
Traceback (most recent call last):
Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 313, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1847, in task
    self.f(*self.args)
    ~~~~~~^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1912, in multipass
    barrier.wait()
    ~~~~~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/managers.py", line 1108, in wait
    return self._callmethod('wait', (timeout,))
           ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/managers.py", line 840, in _callmethod
    raise convert_to_error(kind, result)
threading.BrokenBarrierError
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 313, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1847, in task
    self.f(*self.args)
    ~~~~~~^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1912, in multipass
    barrier.wait()
    ~~~~~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/managers.py", line 1108, in wait
    return self._callmethod('wait', (timeout,))
           ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/managers.py", line 840, in _callmethod
    raise convert_to_error(kind, result)
threading.BrokenBarrierError
ERROR


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 5176, in test_wait_integer
    self.assertLess(delta, expected + 2)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
AssertionError: 5.0250674188137054 not less than 5


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/test_eintr.py", line 17, in test_all
    script_helper.run_test_script(script)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/support/script_helper.py", line 316, in run_test_script
    raise AssertionError(f"{name} failed")
AssertionError: script _test_eintr.py failed


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1927, in test_barrier
    self.run_threads(self.multipass, (self.barrier, results, passes))
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1900, in run_threads
    f(*args)
    ~^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 1912, in multipass
    barrier.wait()
    ~~~~~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/managers.py", line 1108, in wait
    return self._callmethod('wait', (timeout,))
           ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/managers.py", line 840, in _callmethod
    raise convert_to_error(kind, result)
threading.BrokenBarrierError


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/test_concurrent_futures/executor.py", line 71, in test_map_timeout
    self.assertEqual([None, None], results)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: Lists differ: [None, None] != []


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_eintr.py", line 532, in test_lockf
    self._lock(fcntl.lockf, "lockf")
    ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_eintr.py", line 517, in _lock
    raise Exception("failed to sync child in %.1f sec" % dt)
Exception: failed to sync child in 300.4 sec


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 5169, in test_wait_integer
    self.assertTrue(sem.acquire(timeout=20))
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: False is not true


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 313, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 5329, in child
    join_process(p)
    ~~~~~~~~~~~~^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 105, in join_process
    threading_helper.join_thread(process)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/support/threading_helper.py", line 116, in join_thread
    raise AssertionError(msg)
AssertionError: failed to join the thread in 30.0 seconds
Process Process-236:1:
Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 313, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 5329, in child
    join_process(p)
    ~~~~~~~~~~~~^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 105, in join_process
    threading_helper.join_thread(process)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/support/threading_helper.py", line 116, in join_thread
    raise AssertionError(msg)
AssertionError: failed to join the thread in 30.0 seconds
k


Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 313, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 5329, in child
    join_process(p)
    ~~~~~~~~~~~~^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 105, in join_process
    threading_helper.join_thread(process)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/support/threading_helper.py", line 116, in join_thread
    raise AssertionError(msg)
AssertionError: failed to join the thread in 30.0 seconds
Process Process-392:1:
Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 313, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 5329, in child
    join_process(p)
    ~~~~~~~~~~~~^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 105, in join_process
    threading_helper.join_thread(process)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/support/threading_helper.py", line 116, in join_thread
    raise AssertionError(msg)
AssertionError: failed to join the thread in 30.0 seconds
Process Process-392:1:1:
Traceback (most recent call last):
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 313, in _bootstrap
    self.run()
    ~~~~~~~~^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
    ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 5329, in child
    join_process(p)
    ~~~~~~~~~~~~^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line 105, in join_process
    threading_helper.join_thread(process)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/support/threading_helper.py", line 116, in join_thread
    raise AssertionError(msg)
AssertionError: failed to join the thread in 30.0 seconds
k

…rning (pythonGH-117668) * Fix `test_strptime` raises a DeprecationWarning * Ignore deprecation warnings where appropriate. * Update Lib/test/datetimetester.py This is follow on work to silence unnecessary warnings from the test suite that changes for python#70647 added.

Fix test_strptime raises a DeprecationWarning

1f794a7

bedevere-app bot added the tests Tests in the Lib/test dir label Apr 9, 2024

bedevere-app bot mentioned this pull request Apr 9, 2024

test_strptime raises a DeprecationWarning #117655

Closed

nineteendo marked this pull request as ready for review April 9, 2024 08:07

nineteendo requested review from pganssle and abalkin as code owners April 9, 2024 08:07

bedevere-app bot added the awaiting review label Apr 9, 2024

nineteendo marked this pull request as draft April 9, 2024 09:55

bedevere-app bot removed the awaiting review label Apr 9, 2024

nineteendo added 2 commits April 9, 2024 12:11

Revert "Fix test_strptime raises a DeprecationWarning"

b6b76be

This reverts commit 1f794a7.

Fix test_strptime raises a DeprecationWarning

9fc8691

nineteendo marked this pull request as ready for review April 9, 2024 12:03

bedevere-app bot added the awaiting review label Apr 9, 2024

erlend-aasland added the skip news label Apr 9, 2024

ignore deprecation warnings

3f9d6af

This comment was marked as outdated.

Sign in to view

erlend-aasland requested a review from gpshead April 18, 2024 12:40

Eclips4 approved these changes May 11, 2024

View reviewed changes

Lib/test/datetimetester.py Outdated Show resolved Hide resolved

bedevere-app bot added awaiting core review and removed awaiting review labels May 11, 2024

Update Lib/test/datetimetester.py

5edba62

gpshead approved these changes May 11, 2024

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels May 11, 2024

gpshead merged commit abead54 into python:main May 11, 2024
33 checks passed

bedevere-app bot removed the awaiting merge label May 11, 2024

nineteendo deleted the fix-test.test_strptime branch May 11, 2024 21:46

gpshead added the needs backport to 3.13 bugs and security fixes label May 11, 2024

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 11, 2024

JelleZijlstra mentioned this pull request May 28, 2024

backport a9a74da 3.13 #119642

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-117655: Fix `test_strptime` raises a DeprecationWarning #117668

gh-117655: Fix `test_strptime` raises a DeprecationWarning #117668

nineteendo commented Apr 9, 2024 •

edited by bedevere-app bot

Loading

This comment was marked as outdated.

erlend-aasland commented Apr 18, 2024

erlend-aasland commented Apr 18, 2024

nineteendo commented Apr 18, 2024

nineteendo commented May 11, 2024 •

edited

Loading

nineteendo commented May 11, 2024

gpshead commented May 11, 2024

miss-islington-app bot commented May 11, 2024

bedevere-app bot commented May 11, 2024

bedevere-bot commented May 12, 2024

bedevere-bot commented May 12, 2024

gh-117655: Fix test_strptime raises a DeprecationWarning #117668

gh-117655: Fix test_strptime raises a DeprecationWarning #117668

Conversation

nineteendo commented Apr 9, 2024 • edited by bedevere-app bot Loading

This comment was marked as outdated.

erlend-aasland commented Apr 18, 2024

erlend-aasland commented Apr 18, 2024

nineteendo commented Apr 18, 2024

nineteendo commented May 11, 2024 • edited Loading

nineteendo commented May 11, 2024

gpshead commented May 11, 2024

miss-islington-app bot commented May 11, 2024

bedevere-app bot commented May 11, 2024

bedevere-bot commented May 12, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

bedevere-bot commented May 12, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

gh-117655: Fix `test_strptime` raises a DeprecationWarning #117668

gh-117655: Fix `test_strptime` raises a DeprecationWarning #117668

nineteendo commented Apr 9, 2024 •

edited by bedevere-app bot

Loading

nineteendo commented May 11, 2024 •

edited

Loading