-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-112536: Set up TSAN CI for free-threading #116555
Changes from all commits
bd5e85a
a7a3b08
a7f4826
84bccfb
aa15f16
0f72690
2ce5cdd
05a5882
0b68814
d2a4476
f641cad
dd88d4a
6c96e41
179bacd
691d0e4
d89f932
d833618
33317e7
cade95e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -472,6 +472,29 @@ jobs: | |
- name: Tests | ||
run: xvfb-run make test | ||
|
||
build_tsan_free_threading: | ||
name: 'Thread sanitizer (free-threading)' | ||
runs-on: ubuntu-20.04 | ||
timeout-minutes: 60 | ||
needs: check_source | ||
if: needs.check_source.outputs.run_tests == 'true' | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Install Dependencies | ||
run: sudo ./.github/workflows/posix-deps-apt.sh | ||
- name: Set up GCC-10 for ASAN | ||
uses: egor-tensin/setup-gcc@v1 | ||
with: | ||
version: 11 | ||
- name: Configure CPython | ||
run: ./configure --disable-gil --with-thread-sanitizer | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we want |
||
- name: Build CPython | ||
run: make -j4 | ||
- name: Display build info | ||
run: make pythoninfo | ||
- name: Tests | ||
run: ./python -m test --pgo -j4 # Reduce test scope | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we'll want a configuration specifically for tsan. Maybe a Brett had a list of tests that fail with swtaarrs@1fe9165#diff-590c02490d066378045dd48d62e86dc85d3fb4ad934b6a2b2b0b1112e59eaefb |
||
|
||
# CIFuzz job based on https://google.github.io/oss-fuzz/getting-started/continuous-integration/ | ||
cifuzz: | ||
name: CIFuzz | ||
|
@@ -561,6 +584,7 @@ jobs: | |
build_windows, | ||
build_windows_free_threading, | ||
build_asan, | ||
build_tsan_free_threading, | ||
' | ||
|| '' | ||
}} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -446,6 +446,7 @@ _PyMem_ArenaFree(void *Py_UNUSED(ctx), void *ptr, | |
/***************************/ | ||
|
||
static int | ||
_Py_NO_SANITIZE_THREAD | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've had a better experience using suppression lists rather than marking functions as
See https://github.com/google/sanitizers/wiki/ThreadSanitizerSuppressions |
||
set_default_allocator_unlocked(PyMemAllocatorDomain domain, int debug, | ||
PyMemAllocatorEx *old_alloc) | ||
{ | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version says "11" but the step name says "GCC-10"